Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How many requests/responses are the different endpoints doing? #1499

Closed
Maharacha opened this issue Sep 27, 2024 · 3 comments
Closed

How many requests/responses are the different endpoints doing? #1499

Maharacha opened this issue Sep 27, 2024 · 3 comments

Comments

@Maharacha
Copy link

Is there information somewhere exactly how many requests and responses each sidecar endpoint is doing to the backend node? Or do you have a suggestion how we could generate such data in an easy way? I need for each endpoint but also for the different combination of parameters.

Thanks!

@Imod7
Copy link
Contributor

Imod7 commented Oct 1, 2024

Hello @Maharacha ! EDITED ANSWER

We recently added additional Prometheus metrics to improve monitoring of Sidecar's performance so maybe one of those metrics can cover your needs. We are also in the process of optimizing the code for better efficiency and here are some relevant PRs : #1483 and #1489 which are linked to the umbrella issue #1361.

If you would like metrics at a more granular level (counting every single call made to the node), a possible solution would be to add a custom metric (e.g. a counter) which increases in every call found in the Controller and Service of each endpoint, including variations based on different combination of parameters.

If you would like to try this out, you are welcome to open a PR, and we will be happy to review it and guide you through the process. Otherwise, we are planning to add metrics counting requests and responses per different parameter combination in the future since other tasks have priority right now.

@Maharacha
Copy link
Author

Thanks for the thorough answer @Imod7 ! It's enough for now to know what options we have to extract that kind of information.

@Imod7
Copy link
Contributor

Imod7 commented Oct 7, 2024

You are welcome!
Also big kudos to @filvecchiato for all the work he has done on the metrics and performance investigation and changes until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants