Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Reduce cloning in GrandpaBlockImport #1483

Open
andresilva opened this issue Jan 18, 2019 · 0 comments
Open

Reduce cloning in GrandpaBlockImport #1483

andresilva opened this issue Jan 18, 2019 · 0 comments
Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint.
Milestone

Comments

@andresilva
Copy link
Contributor

When importing or finalizing a block through GrandpaBlockImport it currently eagerly clones the existing authority_set in case any intermediary operation fails and it is necessary to revert.

// TODO [andre]: clone only when changed
let old_authority_set = authority_set.clone();

@andresilva andresilva added I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. M4-core labels Jan 18, 2019
@andresilva andresilva added this to the As-and-when milestone Jan 18, 2019
@gavofyork gavofyork removed the M4-core label Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint.
Projects
None yet
Development

No branches or pull requests

2 participants