Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

DigestItem refactoring for swappable consensus #2083

Closed
rphmeier opened this issue Mar 22, 2019 · 2 comments
Closed

DigestItem refactoring for swappable consensus #2083

rphmeier opened this issue Mar 22, 2019 · 2 comments
Assignees
Labels
J0-enhancement An additional feature request.
Milestone

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Mar 22, 2019

Related to #1365

Right now, the DigestItem::Seal in sr-primitives is very Aura-specific. As part of Swappable Consensus · Issue #1304 · paritytech/substrate · GitHub we are moving a lot of stuff to be based on ConsensusEngineIds. For BABE this would be the array ['b'B', b'A', b'B', b'E'].

Currently DigestItem::<SealSignature>::Seal(u64, SealSignature)

We'd like it to be defined as DigestItem::Seal(ConsensusEngineId, Vec<u8>). This will lead to the Signature parameter being removed from DigestItem and all containing structs (this is a win!).

Unfortunately, that's not backwards compatible with the old Aura implementation and will break things.

To make it backwards compatible, we will originally add this as DigestItem::Consensus(ConsensusEngineId, Vec<u8>) and write a fn start_aura2.

@rphmeier rphmeier added the J0-enhancement An additional feature request. label Mar 22, 2019
@rphmeier rphmeier added this to the 1.1 milestone Mar 22, 2019
@rphmeier rphmeier changed the title DigestItem refactoring DigestItem refactoring for swappable consensus Mar 22, 2019
@Demi-Marie Demi-Marie self-assigned this Mar 22, 2019
@Demi-Marie
Copy link
Contributor

@rphmeier does this still depend on #1365?

@rphmeier
Copy link
Contributor Author

No, I don't think so. Removed that from the issue description.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

No branches or pull requests

2 participants