You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Right now, the DigestItem::Seal in sr-primitives is very Aura-specific. As part of Swappable Consensus · Issue #1304 · paritytech/substrate · GitHub we are moving a lot of stuff to be based on ConsensusEngineIds. For BABE this would be the array ['b'B', b'A', b'B', b'E'].
Currently DigestItem::<SealSignature>::Seal(u64, SealSignature)
We'd like it to be defined as DigestItem::Seal(ConsensusEngineId, Vec<u8>). This will lead to the Signature parameter being removed from DigestItem and all containing structs (this is a win!).
Unfortunately, that's not backwards compatible with the old Aura implementation and will break things.
To make it backwards compatible, we will originally add this as DigestItem::Consensus(ConsensusEngineId, Vec<u8>) and write a fn start_aura2.
The text was updated successfully, but these errors were encountered:
Related to #1365
Right now, the
DigestItem::Seal
insr-primitives
is very Aura-specific. As part of Swappable Consensus · Issue #1304 · paritytech/substrate · GitHub we are moving a lot of stuff to be based onConsensusEngineId
s. For BABE this would be the array['b'B', b'A', b'B', b'E']
.Currently
DigestItem::<SealSignature>::Seal(u64, SealSignature)
We'd like it to be defined as
DigestItem::Seal(ConsensusEngineId, Vec<u8>)
. This will lead to theSignature
parameter being removed fromDigestItem
and all containing structs (this is a win!).Unfortunately, that's not backwards compatible with the old Aura implementation and will break things.
To make it backwards compatible, we will originally add this as
DigestItem::Consensus(ConsensusEngineId, Vec<u8>)
and write afn start_aura2
.The text was updated successfully, but these errors were encountered: