Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Generic strongly-typed justifications and consensus objects #793

Open
rphmeier opened this issue Sep 24, 2018 · 0 comments
Open

Generic strongly-typed justifications and consensus objects #793

rphmeier opened this issue Sep 24, 2018 · 0 comments
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Milestone

Comments

@rphmeier
Copy link
Contributor

A lot of code like network and client is generic over the Block type but does not deal with justifications for those blocks. As such, we are limited to using Vec<u8> justifications in order to generalize over consensus engines.

It might be faster, less error-prone, and more convenient to have a Chain trait that encapsulates both Block and Consensus and make code generic over that instead. But it remains to be seen how this can be made compatible with hard forks of consensus.

@rphmeier rphmeier added the I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. label Sep 24, 2018
@rphmeier rphmeier added this to the As-and-when milestone Sep 24, 2018
liuchengxu added a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
* Remove zombie intentions

* Nit

* Remove intention identity only

* Every call in staking should check the intention identity first

* Nit

* Nits
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
None yet
Development

No branches or pull requests

1 participant