Skip to content

Commit 2b4c9e0

Browse files
committed
fix: Removed type overrides
1 parent 8e380d7 commit 2b4c9e0

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/main/java/com/parseable/temporal/ParseableConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public static ParseableConfig fromEnv() {
8080
.logStream(envOrDefault("PARSEABLE_LOG_STREAM", "temporal-logs"))
8181
.traceStream(envOrDefault("PARSEABLE_TRACE_STREAM", "temporal-traces"))
8282
.temporalHost(envOrDefault("PARSEABLE_TEMPORAL_HOST", "localhost:7233"))
83-
.temporalNamespace(envOrDefault("PARSEABLE_TEMPORAL_NAMESPACE", "default"))
83+
.temporalNamespace(System.getenv("PARSEABLE_TEMPORAL_NAMESPACE"))
8484
.serviceName(envOrDefault("PARSEABLE_SERVICE_NAME", "temporal-worker"))
8585
.batchExportTimeoutMs(
8686
Long.parseLong(envOrDefault("PARSEABLE_BATCH_EXPORT_TIMEOUT_MS", "5000")))
@@ -146,7 +146,7 @@ public static final class Builder {
146146
private String logStream = "temporal-logs";
147147
private String traceStream = "temporal-traces";
148148
private String temporalHost = "localhost:7233";
149-
private String temporalNamespace = "default";
149+
private String temporalNamespace;
150150
private String serviceName = "temporal-worker";
151151
private Duration batchExportTimeout = Duration.ofMillis(5000);
152152

src/main/java/com/parseable/temporal/ParseablePlugin.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,10 @@ public ParseablePlugin(ParseableConfig config) {
6464
@Override
6565
public void configureWorkflowClient(@Nonnull WorkflowClientOptions.Builder builder) {
6666
super.configureWorkflowClient(builder);
67-
builder.setNamespace(config.getTemporalNamespace());
67+
String ns = config.getTemporalNamespace();
68+
if (ns != null && !ns.isEmpty()) {
69+
builder.setNamespace(ns);
70+
}
6871
WorkflowClientInterceptor[] existing = builder.build().getInterceptors();
6972
if (existing != null) {
7073
for (WorkflowClientInterceptor interceptor : existing) {

0 commit comments

Comments
 (0)