Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet Package is out of date #400

Closed
bugnuker opened this issue Jun 12, 2023 · 8 comments
Closed

NuGet Package is out of date #400

bugnuker opened this issue Jun 12, 2023 · 8 comments
Assignees

Comments

@bugnuker
Copy link

The NuGet package is out of date and does not include some PRs, specifically this one: #310

The package was last built in September 2022 and the PR in question is from Oct 15th, 2022.

The current demos in the source code do not work with the NuGet package due to the outdated ResidentKeyRequirement change in the NuGet package.

Recommend updating pipelines to build/publish nuget packages.

@bugnuker
Copy link
Author

Any plans to update the Nuget package? Has this been abandoned?

@abergs
Copy link
Collaborator

abergs commented Jun 19, 2023

I would love a PR that adds a pr that publishes a pre-release version of the Nuget package. Don't know if we should publish to nuget/github repo, but that would be great.

FYI A nuget package release is upcoming. Keeping this ticket open for transparency until it's released.

@abergs
Copy link
Collaborator

abergs commented Jun 20, 2023

A 4.0.0-beta1 nuget package has been released from the 4.0.0-beta1 tag, based from master

@bugnuker
Copy link
Author

Great, Thank you!

I am working on testing it. So far, only breaking change I've seen is the property "Aaguid" changed to "AaGuid". Will post back here if I find other items. Thanks!

@abergs
Copy link
Collaborator

abergs commented Jun 21, 2023

@bugnuker Thank you!
Will drop another Beta soon that contains #356 as well

@abergs abergs closed this as completed Jun 22, 2023
@abergs
Copy link
Collaborator

abergs commented Jun 22, 2023

4.0.0-beta2 dropped today.

@bugnuker
Copy link
Author

beta2 fails to compile with existing code - something change with the callback?

There is no argument given that corresponds to the required parameter 'isUserHandleOwnerOfCredentialIdCallback' of 'Fido2.MakeAssertionAsync(AuthenticatorAssertionRawResponse, AssertionOptions, byte[], List<byte[]>, uint, IsUserHandleOwnerOfCredentialIdAsync, CancellationToken)

@abergs
Copy link
Collaborator

abergs commented Jun 26, 2023

Yes, there are a number of breaking changes in v4. If beta1 works for you than this should show you the diff of beta2:
4.0.0-beta1...v4.0.0-beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants