Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In "am_demodulate()" for the normalization step there are unneeded operations #16

Open
pat8901 opened this issue Oct 19, 2024 · 1 comment
Open

In "am_demodulate()" for the normalization step there are unneeded operations #16

pat8901 opened this issue Oct 19, 2024 · 1 comment
Assignees
@pat8901
Labels
optimization optimization request

Comments

@pat8901
Copy link
Owner

pat8901 commented Oct 19, 2024

Problem

A range of indices are normalized when they don't need to be. A previous step has already set them to zero.

Solution

The indices that are zero should be ignored. One could also remember the range of non-zero numbers and loop over it instead of testing for 0.
@pat8901 pat8901 added the optimization optimization request label Oct 19, 2024
@pat8901 pat8901 self-assigned this Oct 19, 2024
@pat8901
Copy link
Owner Author

pat8901 commented Oct 19, 2024

Also, why is division by 5512.5 chosen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pat8901 pat8901

Labels
optimization optimization request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pat8901