what about support for files in archives?

[fommil]

One of the core strengths of nio is that it works on abstract filesystems, such as jar/zip files. We use this to great effect in ENSIME.

Will you be supporting this usecase?

We'd certainly like to use a standard platform library than roll our own, see:

https://github.com/ensime/ensime-server/blob/2.0/util/src/main/scala/org/ensime/util/ensimefile.scala
https://github.com/ensime/ensime-server/blob/2.0/util/src/main/scala/org/ensime/util/path.scala
(deprecating) https://github.com/ensime/ensime-server/blob/2.0/util/src/main/scala/org/ensime/util/file.scala
(deprecating) https://github.com/ensime/ensime-server/blob/2.0/util/src/main/scala/org/ensime/util/io.scala

[fommil]

(btw, key to the abstract pattern is that there needs to be a clean way to close that abstract filesystem. Keeping jars/zips open is really really bad on Windows https://github.com/fommil/class-monkey )

[pathikrit]

Hi, the DNA of better-files was supposed to just add useful implicit defs to java.util.File and thus it is currently only serves as File I/O util using NIO. But there's no reason, it can expand its horizon and work on other filesystems - I just did not have anything immediate in my mind but PRs on this is VERY WELCOME. A lot of the other codes in the files you posted are already in e.g. RichOutpustStream.drain are already in better-files (see OutputStreamOps)

[fommil]

No description provided.

[jvican]

@fommil This is a great idea and I can see how it would also be super useful for lots of projects I have in mind.

We'll be publishing this week an official artifact of better-files (/cc @pathikrit), so perhaps we can use that as the first starting point to migrate to it in Ensime and create these abstractions in a PR. What do you think?

[fommil]

No description provided.

[fommil]

@pathikrit I really wish I could help out but unfortunately my time to contribute to community projects is already incredibly limited and I have a TODO list longer than I can possibly keep. I'll have to be a bit rubbish and just say: I'm here to help you to take what you want from ENSIME, but I can't commit any time to raise any PRs myself.

[jvican]

@fommil That makes perfect sense.

If you grant us an Apache 2 license, I could put this a Scala Center hackathon ticket that people could hack on. It wouldn't be difficult to port what you guys have in Ensime to this repository. I think the use case is really worth it. WDYT?

[fommil]

Yeah, that's fine. I don't think it will be as simple as copy/paste, the API probably needs to be designed to reflect the Path concept of NIO on virtual file systems. I'm not sure if limiting it to just File is going to be as useful as in could be.

Btw we are still missing a lot of the needed functionality, e.g. some way of streaming through the jar contents in an efficient way. My API is random access, and hence very slow for that use case (we currently stream using VFS)

[pathikrit]

@fommil: Let's not close issues without any comments

[fommil]

recreate the ticket if you want to track it. I'm closing all my scala tickets.

[fommil]

Come on... I'm trying to clean up my github search so I can see all my open tickets, as my personal TODO page, and I don't want any scala tickets showing up there. If you want to track this open a new ticket.

[pathikrit]

Sorry, this issue is not resolved. I won't close it till it is resolved.