Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run on more events #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gardar
Copy link

@gardar gardar commented Feb 16, 2023

Fixes: #341

@gardar
Copy link
Author

gardar commented Feb 17, 2023

Not sure if the failing CI is related to the change, thoughts @patrickjahns ?

@patrickjahns
Copy link
Owner

@gardar

Unfortunately it is the case - I've merged a couple of dependency PRs yesterday and the main branch is still green:
https://github.com/patrickjahns/version-drafter-action/actions/runs/4198960074/jobs/7283253356

Most likely it's an issue with https://github.com/release-drafter/release-drafter - maybe it's a well known issue and a fix is available upstream and you could bump the version used

On a different note - can you please share why the change is needed ? Why do you want to / need to run the action on different events than a push ( to main ) ?

@gardar
Copy link
Author

gardar commented Feb 17, 2023

Ok rebased upstream, let's see if it fixes it.

In my case I want to be certain that the release workflow only runs upon successful merge to default branch and I don't want it to run if directly pushed to the default branch. But I see other use cases as well, for example if you only want to trigger a release workflow on workflow_dispatch, etc.

@gardar
Copy link
Author

gardar commented Feb 17, 2023

Ok so nope, sadly a simple rebase wasn't enough.

A quick google search for the error led me to this: release-drafter/release-drafter#578

@patrickjahns
Copy link
Owner

Most likely updating the dependency can work.
Tests cases should catch any issues.

If you want to allow more events, it would then be great to have at least 1-2 more tests cases covering anything besides a push scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use action with merged pull request trigger
2 participants