Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Watch process doesn’t regenerate site #371

Open
jannisborgers opened this issue Aug 16, 2016 · 8 comments
Open

Watch process doesn’t regenerate site #371

jannisborgers opened this issue Aug 16, 2016 · 8 comments
Labels

Comments

@jannisborgers
Copy link

jannisborgers commented Aug 16, 2016

I’m not sure when this happened, but the watch process doesn’t regenerate the site anymore. The changes I made to a molecule aren’t updated in the organism it was included in (When running the Pattern Lab server, the changes are updated in the original pattern and the page is reloaded as well). When I generate the site manually with --generate, the changes are propagated correctly.

I’m using the Twig Edition on PHP.

Screenshot of watch process

The „has changed“ message pop up when I save the file.

@jannisborgers
Copy link
Author

My workaround right now is to use CodeKit:

  • add twig as a generic file extension in CodeKits project settings to watch for changes
  • add the following hook to the project:
    When the full path contains path/to/project (careful!) and also contains .twig, run the following shell command:

cd path/to/project
php core/console --generate

I also use CodeKit’s auto-reload. This way the browser reloads when both .scss and .twig files change. It reloads twice, though.

@dmolsen
Copy link
Member

dmolsen commented Aug 17, 2016

@jannisborgers -

Just checking in with you. No intertubes at home at the moment so I wasn't able to look into this last night. Opening the issue now so I can view it offline and check on it tonight.

@dmolsen dmolsen self-assigned this Aug 17, 2016
@dmolsen dmolsen added the bug label Aug 17, 2016
@philippebarbosa
Copy link

Hi,
any news about this bug ?
We are facing the same problem here. watching but no regenerating. Thanks !

@Bridn
Copy link

Bridn commented Sep 8, 2016

The error occurs only when I include or extend an other .twig. The watch message "has changed" appears but it doesn't refresh the template

@Loque-
Copy link

Loque- commented Sep 13, 2016

I can also confirm this issue. Just want to say a quick kudos for all the awesome work, we are finally getting into Patternlab and this project is awesome, thanks so much.

@wwhurley
Copy link

wwhurley commented Aug 6, 2018

Any updates on this issue?

@bicrazor
Copy link

I'm having the same issue, any chance this will be looked at soon?

@JacqueH
Copy link

JacqueH commented Sep 24, 2019

I find that the watch process does not reliably regenerate the site if it has previously timed out.
Mac OSX 10.14.6
php version 7.1.23 (Feb 22 2019)
I'll start pattern lab by running php core/console --server --with-watch after 10 minutes (which is too short, as others have observed in a different thread!) the process stops if there has been no console output. I will restart using the same command but now when I save a change to a pattern (for instance) the site is never updated.
Possibly related: failures are silent and seem to cause the system to go unresponsive. That is, if I have a problem in a .json file (for instance), it might be revealed by --generate, but no error is displayed if I'm currently running the server --with-watch. This might be why nothing re-generates automatically.
Will be happy for any insights. It's hard enough getting the patterns and data right without having to frequently restart the whole shebang.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants