Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FavoriteButton - migrate from ODH and document API #31

Open
nicolethoen opened this issue Oct 9, 2024 · 0 comments
Open

FavoriteButton - migrate from ODH and document API #31

nicolethoen opened this issue Oct 9, 2024 · 0 comments
Milestone

Comments

@nicolethoen
Copy link
Contributor

The code for this component currently lives at https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/components/FavoriteButton.tsx

This new components should be built using PF6.

A PF6 version of this component lives in the current PF6 migration POC PR: opendatahub-io/odh-dashboard#3038

The API of the new component should match the API of the component in RHOAI.
We can improve a11y, right-to-left language support, replace deprecated components under the hood, or generally clean up the implementation, as long as the API works in RHOAI.

@nicolethoen nicolethoen added this to the 2024.Q4 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to assign
Development

No branches or pull requests

1 participant