Skip to content

Commit 6ea3950

Browse files
fix: remove redundant aria-describedby attributes (#243)
* fix: remove redundant aria-describedby attributes * Update packages/module/src/ResponseActions/ResponseActionButton.tsx Co-authored-by: Rebecca Alpert <[email protected]> --------- Co-authored-by: Rebecca Alpert <[email protected]>
1 parent 3741773 commit 6ea3950

File tree

7 files changed

+2
-9
lines changed

7 files changed

+2
-9
lines changed

packages/module/src/ChatbotHeader/ChatbotHeaderMenu.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export const ChatbotHeaderMenu: React.FunctionComponent<ChatbotHeaderMenuProps>
2525
<Button
2626
className="pf-chatbot__button--toggle-menu"
2727
variant="plain"
28-
aria-describedby="pf-chatbot__tooltip--toggle-menu"
2928
onClick={onMenuToggle}
3029
aria-label={menuAriaLabel}
3130
icon={

packages/module/src/Message/CodeBlockMessage/CodeBlockMessage.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ const CodeBlockMessage = ({ children, className, ...props }: JSX.IntrinsicElemen
5454
aria-label="Copy code button"
5555
variant="plain"
5656
className="pf-chatbot__button--copy"
57-
aria-describedby={tooltipID}
5857
onClick={(event) => handleCopy(event, children)}
5958
>
6059
{copied ? <CheckIcon /> : <CopyIcon />}

packages/module/src/MessageBar/AttachButton.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ const AttachButtonBase: React.FunctionComponent<AttachButtonProps> = ({
5555
variant="plain"
5656
ref={innerRef}
5757
className={`pf-chatbot__button--attach ${className ?? ''}`}
58-
aria-describedby="pf-chatbot__tooltip--attach"
5958
aria-label={props['aria-label'] || 'Attach Button'}
6059
isDisabled={isDisabled}
6160
onClick={onClick ?? open}

packages/module/src/MessageBar/MicrophoneButton.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ export const MicrophoneButton: React.FunctionComponent<MicrophoneButtonProps> =
9595
<Button
9696
variant="plain"
9797
className={`pf-chatbot__button--microphone ${isListening ? 'pf-chatbot__button--microphone--active' : ''} ${className ?? ''}`}
98-
aria-describedby="pf-chatbot__tooltip--use-microphone"
9998
aria-label={props['aria-label'] || 'Microphone Button'}
10099
onClick={isListening ? stopListening : startListening}
101100
icon={

packages/module/src/MessageBar/SendButton.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ export const SendButton: React.FunctionComponent<SendButtonProps> = ({
3636
<Button
3737
className={`pf-chatbot__button--send ${className ?? ''}`}
3838
variant="link"
39-
aria-describedby="pf-chatbot__tooltip--send"
4039
aria-label={props['aria-label'] || 'Send Button'}
4140
onClick={onClick}
4241
icon={

packages/module/src/MessageBox/JumpButton.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const JumpButton: React.FunctionComponent<JumpButtonProps> = ({ position, isHidd
2525
variant="plain"
2626
className={`pf-chatbot__jump pf-chatbot__jump--${position} ${isHidden && `pf-chatbot__jump--${position}--hidden`}`}
2727
aria-label={`Jump ${position} button`}
28-
aria-describedby={`pf-chatbot__tooltip--jump-${position}`}
2928
onClick={onClick}
3029
>
3130
<Icon iconSize="xl" isInline>

packages/module/src/ResponseActions/ResponseActionButton.tsx

+2-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react';
22
import { Button, Icon, Tooltip, TooltipProps } from '@patternfly/react-core';
33

44
export interface ResponseActionButtonProps {
5-
/** Aria-label for the button */
5+
/** Aria-label for the button. Defaults to the value of the tooltipContent if none provided */
66
ariaLabel?: string;
77
/** Icon for the button */
88
icon: React.ReactNode;
@@ -40,8 +40,7 @@ export const ResponseActionButton: React.FunctionComponent<ResponseActionButtonP
4040
<Button
4141
variant="plain"
4242
className={`pf-chatbot__button--response-action ${className ?? ''}`}
43-
aria-describedby={`pf-chatbot__tooltip-response-action-${tooltipContent}`}
44-
aria-label={ariaLabel}
43+
aria-label={ariaLabel || tooltipContent}
4544
icon={
4645
<Icon isInline size="lg">
4746
{icon}

0 commit comments

Comments
 (0)