Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pf-text-input property validated missing options #2818

Open
yaacov opened this issue Aug 6, 2024 · 1 comment
Open

pf-text-input property validated missing options #2818

yaacov opened this issue Aug 6, 2024 · 1 comment
Assignees
Labels
design system Updates or issues to align components to the Red Hat Design System. priority: low Severity level: 3 update component request

Comments

@yaacov
Copy link

yaacov commented Aug 6, 2024

Component name: pf-text-input

property validated missing options

Design specification updates

Elements allow:

/**
   * Value to indicate if the input is modified to show that validation state.
   * If set to success, input will be modified to indicate valid state.
   * If set to warning,  input will be modified to indicate warning state.
   * Invalid inputs will display an error state
   */
  @property({ reflect: true }) validated?: 'success' | 'warning';

Ref: https://github.com/patternfly/patternfly-elements/blob/main/elements/pf-text-input/pf-text-input.ts#L160

React 4 allow:

/** Variant styling of the helper text item. */
 variant?: 'default' | 'indeterminate' | 'warning' | 'success' | 'error';

Ref: https://github.com/patternfly/patternfly-react/blob/v4/packages/react-core/src/components/TextInput/TextInput.tsx#L44

@yaacov yaacov added design system Updates or issues to align components to the Red Hat Design System. priority: low Severity level: 3 update component request labels Aug 6, 2024
@bennypowers
Copy link
Member

bennypowers commented Aug 6, 2024

some context: previously we determined that the built-in :invalid pseudo selector should be prefered, but developer feedback has shown that adding a pattern regex is not desired or ergonomic in all cases where error state should be presented, so this is an acceptable criteria.

@yaacov you're welcome to grab this one, and thank you for the issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design system Updates or issues to align components to the Red Hat Design System. priority: low Severity level: 3 update component request
Projects
None yet
Development

No branches or pull requests

2 participants