From 86c16fd134996b16cccc4c67b9152f8a9109c8b2 Mon Sep 17 00:00:00 2001 From: Mark Franceschelli <39063664+mfrances17@users.noreply.github.com> Date: Wed, 18 Dec 2024 10:55:29 -0500 Subject: [PATCH] refactor(misc): Remove aria-hidden from icons (#11339) * refactor(misc): Remove aria-hidden from icons * update snap for failing test --- .../Alert/AlertToggleExpandButton.tsx | 2 +- .../src/components/BackToTop/BackToTop.tsx | 2 +- .../CalendarMonth/CalendarMonth.tsx | 4 +- .../src/components/Card/CardHeader.tsx | 2 +- .../Card/examples/CardExpandable.tsx | 2 +- .../Card/examples/CardExpandableWithIcon.tsx | 2 +- .../Card/examples/CardHeaderInCardHead.tsx | 2 +- .../examples/CardOnlyActionsInCardHead.tsx | 2 +- .../Card/examples/CardWithImageAndActions.tsx | 2 +- .../ClipboardCopy/ClipboardCopyToggle.tsx | 2 +- ...dCopyInlineCompactWithAdditionalAction.tsx | 2 +- .../DataList/examples/DataListActions.tsx | 2 +- .../DataList/examples/DataListCheckboxes.tsx | 6 +-- .../examples/DataListClickableRows.tsx | 4 +- .../DataList/examples/DataListExpandable.tsx | 6 +-- .../examples/DataListMixedExpandable.tsx | 6 +-- .../examples/DataListWidthModifiers.tsx | 4 +- .../DualListSelectorTreeItem.tsx | 2 +- .../DualListSelectorComplexOptionsActions.tsx | 4 +- .../ExpandableSection/ExpandableSection.tsx | 2 +- .../ExpandableSectionToggle.tsx | 2 +- .../components/Form/FormFieldGroupToggle.tsx | 2 +- .../components/HelperText/HelperTextItem.tsx | 6 +-- .../src/components/Label/LabelGroup.tsx | 2 +- .../src/components/Menu/MenuItem.tsx | 8 ++-- .../src/components/Menu/MenuItemAction.tsx | 2 +- .../Menu/examples/MenuOptionMultiSelect.tsx | 2 +- .../Menu/examples/MenuOptionSingleSelect.tsx | 2 +- .../Menu/examples/MenuWithActions.tsx | 8 ++-- .../Menu/examples/MenuWithDescription.tsx | 6 +-- .../Menu/examples/MenuWithDrilldown.tsx | 10 ++--- .../examples/MenuWithDrilldownBreadcrumbs.tsx | 8 ++-- .../MenuWithDrilldownInitialState.tsx | 10 ++--- .../MenuWithDrilldownSubmenuFunctions.tsx | 10 ++--- .../Menu/examples/MenuWithFavorites.tsx | 6 +-- .../Menu/examples/MenuWithIcons.tsx | 6 +-- .../src/components/MenuToggle/MenuToggle.tsx | 8 ++-- .../examples/MenuToggleTypeahead.tsx | 2 +- .../src/components/Nav/NavExpandable.tsx | 2 +- .../react-core/src/components/Nav/NavItem.tsx | 2 +- .../NotificationDrawerHeader.tsx | 2 +- .../examples/NotificationDrawerBasic.tsx | 14 +++---- .../examples/NotificationDrawerGroups.tsx | 18 ++++---- .../components/NumberInput/NumberInput.tsx | 4 +- .../Select/examples/SelectMultiTypeahead.tsx | 7 +--- .../examples/SelectMultiTypeaheadCheckbox.tsx | 7 +--- .../SelectMultiTypeaheadCreatable.tsx | 7 +--- .../Select/examples/SelectTypeahead.tsx | 7 +--- .../examples/SelectTypeaheadCreatable.tsx | 7 +--- .../src/components/Switch/Switch.tsx | 4 +- .../__snapshots__/Switch.test.tsx.snap | 4 -- .../TextInputGroup/TextInputGroupMain.tsx | 2 +- .../Toolbar/examples/ToolbarWithFilters.tsx | 2 +- .../components/TreeView/TreeViewListItem.tsx | 2 +- .../src/components/Wizard/WizardHeader.tsx | 7 +--- .../src/components/Wizard/WizardToggle.tsx | 4 +- .../CustomMenus/examples/ActionsMenuDemo.tsx | 8 ++-- .../examples/ContextSelectorDemo.tsx | 2 +- .../examples/DrilldownMenuDemo.tsx | 10 ++--- .../react-core/src/demos/DashboardHeader.tsx | 4 +- .../DataListExpandableControlInToolbar.tsx | 6 +-- .../examples/NotificationDrawerBasic.tsx | 12 +++--- .../examples/NotificationDrawerGrouped.tsx | 20 ++++----- .../react-core/src/demos/PasswordGenerator.md | 2 +- .../src/demos/RTL/examples/PaginatedTable.jsx | 4 +- .../src/demos/RTL/examples/PaginatedTable.tsx | 4 +- .../AlertGroupToastWithNotificationDrawer.tsx | 4 +- .../demos/examples/Card/CardEventsView.tsx | 6 +-- .../examples/Card/CardHorizontalGrid.tsx | 2 +- .../examples/Card/CardUtilizationDemo3.tsx | 2 +- .../DateTimePicker/DateTimePicker.tsx | 2 +- .../Masthead/MastheadWithHorizontalNav.tsx | 4 +- ...stheadWithUtilitiesAndUserDropdownMenu.tsx | 4 +- .../src/demos/examples/Nav/NavFlyout.tsx | 4 +- .../src/demos/examples/Nav/NavHorizontal.tsx | 4 +- .../examples/Nav/NavHorizontalWithSubnav.tsx | 4 +- .../src/demos/examples/Nav/NavManual.tsx | 4 +- .../examples/Page/PageContextSelector.tsx | 4 +- .../Page/PageStickySectionBreadcrumb.tsx | 4 +- .../examples/Page/PageStickySectionGroup.tsx | 4 +- .../Page/PageStickySectionGroupAlternate.tsx | 4 +- .../PrimaryDetail/PrimaryDetailCardView.tsx | 2 +- .../src/demos/examples/Tabs/TabsAndTable.tsx | 2 +- .../DualListSelectorTreeItem.tsx | 2 +- .../components/Wizard/WizardHeader.tsx | 7 +--- .../components/Wizard/WizardToggle.tsx | 4 +- .../ClipboardCopyDemo/ClipboardCopyDemo.tsx | 2 +- .../DualListSelectorWithActionsDemo.tsx | 4 +- .../components/demos/FormDemo/FormDemo.tsx | 2 +- .../components/demos/MenuDemo/MenuDemo.tsx | 41 +++++++------------ .../demos/MenuDemo/MenuDrilldownDemo.tsx | 10 ++--- .../NotificationDrawerBasicDemo.tsx | 12 +++--- .../NotificationDrawerGroupsDemo.tsx | 18 ++++---- .../src/components/Table/DraggableCell.tsx | 2 +- .../src/components/Table/FavoritesCell.tsx | 2 +- .../components/Table/examples/TableTree.tsx | 2 +- .../Table/utils/decorators/sortable.tsx | 2 +- .../Table/utils/decorators/treeRow.tsx | 4 +- .../react-table/src/demos/DashboardHeader.tsx | 4 +- .../demos/examples/TableColumnManagement.tsx | 6 +-- .../TableColumnManagementWithDraggable.tsx | 2 +- .../Table/examples/LegacyTableTree.tsx | 2 +- .../examples/SimpleDropdownExample.tsx | 2 +- .../Select/MultiTypeaheadSelect.tsx | 2 +- .../src/components/Select/TypeaheadSelect.tsx | 7 +--- 105 files changed, 235 insertions(+), 298 deletions(-) diff --git a/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx b/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx index cc54957c516..44cc37d9c37 100644 --- a/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx +++ b/packages/react-core/src/components/Alert/AlertToggleExpandButton.tsx @@ -33,7 +33,7 @@ export const AlertToggleExpandButton: React.FunctionComponent -