Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Update examples/demos to use non deprecated Modal #11191

Closed
Tracked by #10363
tlabaj opened this issue Nov 14, 2024 · 2 comments · Fixed by #11299
Closed
Tracked by #10363

Modal: Update examples/demos to use non deprecated Modal #11191

tlabaj opened this issue Nov 14, 2024 · 2 comments · Fixed by #11299
Assignees
@thatblindgeye
Labels
PF Team
Milestone
2024.Q4

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Nov 14, 2024 •
edited
Loading

Update the following examples/demos that use the deprecated modal to use the new one

  • Label
  • Wizard
  • Multi file upload
  • date picker
@tlabaj tlabaj mentioned this issue Nov 14, 2024
Open
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 14, 2024
@tlabaj tlabaj added this to the 2024.Q4 milestone Nov 14, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Nov 14, 2024
@tlabaj tlabaj changed the title Modal Modal: Update examples/demos to use non deprecated Modal Nov 15, 2024
@tlabaj tlabaj moved this from Backlog to Ready to assign in PatternFly Issues Nov 19, 2024
@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues Nov 20, 2024
@kmcfaul
Copy link
Contributor

kmcfaul commented Nov 27, 2024

I've updated the Modal for the two Table column management demos as a part of #11295

@mfrances17
Copy link
Contributor

I've updated the Wizard's WizardWithinModal example to no longer use the deprecated Modal as part of #11192. There aren't any other uses of the deprecated Modal that I could find in any other Wizard examples or demos.

@thatblindgeye thatblindgeye mentioned this issue Dec 3, 2024
Merged
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Dec 9, 2024
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues Dec 9, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
PF Team
Projects
PatternFly Issues
Status: Done
Milestone
2024.Q4
Development

Successfully merging a pull request may close this issue.

chore(Modal): updated deprecated usage to promoted version thatblindgeye/patternfly-react
4 participants
@mfrances17 @tlabaj @kmcfaul @thatblindgeye