-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core - Add support for React 18 #7142
Comments
@jonkoops Thanks for opening this issue. We are in the process of investigating impact of supporting React 18 available in PF. Our initial investigation found that enzyme adapter does not support React 18. Here is the PR #6899 |
We're looking to update as soon as possible, but we also have dependencies that are not yet ready for React 18. I'd like to help out with the upgrade so I've opened up a PR #7146 to do some ground work. It's open to collaborators so everyone can push commits to it. If you'd like we can coordinate our efforts there. |
@jonkoops that is great that you would to collaborate. I am going to copy the "to do" list from your PR to the issue for tracking. |
Any update on this? |
@nicolethoen could you re-open this issue? Looks like a closing keyword was used in #7706 so this was closed accidentally. |
Is there an ETA for React 18 support? |
React 18 will be supported officially with the next major release of PF, which is tentatively planned to be the first release of 2023. I believe that this PR: #7146 made patternfly React 18 compatible, but I imagine there would still be hiccups fully incorporating it into a React 18 app until we can drop support for React 16 official with that next major release |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Hmmm, I don't think this is stale. There is still some work to be done for proper React 18 support that I haven't gotten to (mostly dependencies). |
Thanks @tlabaj! |
This issue has been automatically marked as stale because it has not had recent activity. |
React 18 support has landed a while ago, closing. |
React 18 has been released, code will have to be adjusted to that it is officially supported.
Checklist
@types/react
and@types/react-dom
([react] React 18 types DefinitelyTyped/DefinitelyTyped#56210).PropsWithChildren
types to components with childrencreateRoot
API for rendering #8027react-monaco-editor
to latest version #8577The text was updated successfully, but these errors were encountered: