Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core - Add support for React 18 #7142

Closed
17 of 20 tasks
jonkoops opened this issue Mar 29, 2022 · 12 comments · Fixed by #7706
Closed
17 of 20 tasks

Core - Add support for React 18 #7142

jonkoops opened this issue Mar 29, 2022 · 12 comments · Fixed by #7706

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Mar 29, 2022

@tlabaj
Copy link
Contributor

tlabaj commented Mar 29, 2022

@jonkoops Thanks for opening this issue. We are in the process of investigating impact of supporting React 18 available in PF. Our initial investigation found that enzyme adapter does not support React 18. Here is the PR #6899
We are currently moving our testing to react-testng-library to remove that dependency. We have several PRs already in the works to do so.
When is your team looking to upgrade?

@jonkoops
Copy link
Contributor Author

We're looking to update as soon as possible, but we also have dependencies that are not yet ready for React 18.

I'd like to help out with the upgrade so I've opened up a PR #7146 to do some ground work. It's open to collaborators so everyone can push commits to it. If you'd like we can coordinate our efforts there.

@tlabaj
Copy link
Contributor

tlabaj commented Apr 5, 2022

@jonkoops that is great that you would to collaborate. I am going to copy the "to do" list from your PR to the issue for tracking.

@mohd-akram
Copy link

Any update on this?

@jonkoops
Copy link
Contributor Author

@nicolethoen could you re-open this issue? Looks like a closing keyword was used in #7706 so this was closed accidentally.

@siwinski
Copy link

Is there an ETA for React 18 support?

@nicolethoen
Copy link
Contributor

React 18 will be supported officially with the next major release of PF, which is tentatively planned to be the first release of 2023.

I believe that this PR: #7146 made patternfly React 18 compatible, but I imagine there would still be hiccups fully incorporating it into a React 18 app until we can drop support for React 16 official with that next major release

@stale
Copy link

stale bot commented Nov 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 27, 2022
@stale stale bot closed this as completed Dec 12, 2022
@jonkoops
Copy link
Contributor Author

Hmmm, I don't think this is stale. There is still some work to be done for proper React 18 support that I haven't gotten to (mostly dependencies).

@tlabaj tlabaj reopened this Dec 13, 2022
Repository owner moved this from Done to Not started in PatternFly Issues Dec 13, 2022
@stale stale bot removed the wontfix label Dec 13, 2022
@tlabaj tlabaj added the Pinned label Dec 13, 2022
@jonkoops
Copy link
Contributor Author

Thanks @tlabaj!

Copy link

github-actions bot commented Jul 7, 2024

This issue has been automatically marked as stale because it has not had recent activity.

@github-actions github-actions bot added the Stale label Jul 7, 2024
@jonkoops
Copy link
Contributor Author

jonkoops commented Jul 8, 2024

React 18 support has landed a while ago, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
5 participants