Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class name updater ignore css vars followup #761

Closed
wise-king-sullyman opened this issue Sep 9, 2024 · 0 comments · Fixed by #778
Closed

class name updater ignore css vars followup #761

wise-king-sullyman opened this issue Sep 9, 2024 · 0 comments · Fixed by #778
Assignees
@wise-king-sullyman
Labels
codemod
Milestone
Penta final release

Comments

@wise-king-sullyman
Copy link
Collaborator

Followup to #754

@adamviktora identified some issues with the above PR after it merged, this issue should resolve them. They are:

  • The classNameMatchers will also match non-global css vars
  • The ${classNameMatches}|global|theme|color should also include chart for chart vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta final release
Development

Successfully merging a pull request may close this issue.

fix(class-name-updater): ignore css vars when running in v6 mode wise-king-sullyman/pf-codemods
2 participants
@wise-king-sullyman @thatblindgeye