Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint token imports should warn that their values have been changed to rem instead of px #787

Open
wise-king-sullyman opened this issue Oct 10, 2024 · 0 comments
Labels

Comments

@wise-king-sullyman
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly#6846

Our breakpoint token values have changed from being in pixels to being in rems, we should warn consumers about that change so that they can make any needed updates to logic that was previously created assuming the values would be in px.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant