Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle star imports and default imports #807

Open
adamviktora opened this issue Nov 25, 2024 · 0 comments
Open

Handle star imports and default imports #807

adamviktora opened this issue Nov 25, 2024 · 0 comments

Comments

@adamviktora
Copy link
Contributor

adamviktora commented Nov 25, 2024

When consumers import things from Patternfly in such manner:

import ReactTable from '@patternfly/react-table';

<ReactTable.Table></ReactTable.Table>


import * as Patternfly from "@patternfly/react-core";

<Patternfly.Button></Patternfly.Button>

then codemods won't be able to find and do a fix.

We should update our helpers / rules to be able to apply fixes in these cases.
Modifying existing rules would probably be too much work, but we should cover these cases in the future for potential V6 -> V7 updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant