Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog tile icon image is vertically offset #21

Open
christianvogt opened this issue Dec 9, 2020 · 5 comments
Open

catalog tile icon image is vertically offset #21

christianvogt opened this issue Dec 9, 2020 · 5 comments

Comments

@christianvogt
Copy link

Describe the issue. What is the expected and unexpected behavior?
When supplying a custom image icon to the CatalogTile, the image is not correctly centered in the icon container in the same when as when supplying an image src url.

image

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.

Paste into catalog tile sample: https://patternfly-react.surge.sh/extensions/catalog-view-tile

import React from 'react';
import { CatalogTile, CatalogTileBadge } from '@patternfly/react-catalog-view-extension';
import CogIcon from '@patternfly/react-icons/dist/js/icons/cog-icon';
import OutlinedCheckCircleIcon from '@patternfly/react-icons/dist/js/icons/outlined-check-circle-icon';
import pfLogo2 from './pfLogo2.svg';

WithMultipleIconBadges = () => (
  <CatalogTile
    id="multiIcon"
    icon={<img src={pfLogo2} style={{width: '100%'}}/>}
    badges={[
      <CatalogTileBadge title="Certified">
        <CogIcon />
      </CatalogTileBadge>,
      <CatalogTileBadge title="USDA Approved">
        <OutlinedCheckCircleIcon className="example-ok-icon" />
      </CatalogTileBadge>
    ]}
    title="Patternfly-React"
    vendor={<React.Fragment>provided by <a href="http://redhat.com">Red Hat</a></React.Fragment>}
    description="description"
  />
)

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
Bug

What is your product and what release version are you targeting?
OpenShift 4.7

@tlabaj
Copy link

tlabaj commented Dec 15, 2020

cc @jcaianirh @rebeccaalpert

@rebeccaalpert rebeccaalpert self-assigned this Dec 15, 2020
@rebeccaalpert
Copy link
Member

Thanks @tlabaj.

@stale
Copy link

stale bot commented Jun 1, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jun 1, 2021
@christianvogt
Copy link
Author

bump

@stale stale bot removed the wontfix This will not be worked on label Jun 1, 2021
@tlabaj
Copy link

tlabaj commented Oct 7, 2021

cc @jessiehuff

@jessiehuff jessiehuff transferred this issue from patternfly/patternfly-react Jan 10, 2023
@jessiehuff jessiehuff moved this to Not started in PatternFly Extensions Mar 8, 2023
@dlabaj dlabaj moved this from Extensions to Backlog in PatternFly Issues Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

4 participants