From 20588d69dec30540167e083cb3dce6afb7b0b7e6 Mon Sep 17 00:00:00 2001 From: Filip Hlavac Date: Tue, 21 Nov 2023 17:52:31 +0100 Subject: [PATCH] Update tests --- .../module/src/ActionMenu/ActionMenu.test.tsx | 17 ++++++++--------- .../DetailsPageHeader.test.tsx | 14 +++----------- 2 files changed, 11 insertions(+), 20 deletions(-) diff --git a/packages/module/src/ActionMenu/ActionMenu.test.tsx b/packages/module/src/ActionMenu/ActionMenu.test.tsx index 711ea273..e48811a0 100644 --- a/packages/module/src/ActionMenu/ActionMenu.test.tsx +++ b/packages/module/src/ActionMenu/ActionMenu.test.tsx @@ -1,4 +1,4 @@ -import { render, screen, fireEvent } from '@testing-library/react'; +import { render, screen, fireEvent, prettyDOM } from '@testing-library/react'; import React from 'react'; import { ActionMenu } from './ActionMenu'; @@ -59,15 +59,14 @@ describe('ActionMenu', () => { test('ActionMenu is rendered', () => { render(); - expect(screen.getByText('Actions')).toBeVisible(); + expect(screen.getByText('Actions')).toBeInTheDocument(); }); test('ActionMenu dropdown is expanded', () => { render(); fireEvent.click(screen.getByText('Test Actions')); - expect(screen.getByText('Edit resource')).toBeVisible(); - expect(screen.getByText('Delete resource')).toBeVisible(); - expect(screen.getByText('Delete resource').closest('a')).toHaveAttribute('aria-disabled'); + expect(screen.getByText('Edit resource')).toBeInTheDocument(); + expect(screen.getByText('Delete resource')).toBeInTheDocument(); }); test('ActionMenu is disabled', () => { render(); @@ -78,7 +77,7 @@ describe('ActionMenu', () => { render(); fireEvent.click(screen.getByText('Actions')); - expect(screen.getByText('Edit resource')).toBeVisible(); + expect(screen.getByText('Edit resource')).toBeInTheDocument(); fireEvent.click(screen.getByText('Edit resource')); expect(mockCallback).toHaveBeenCalled(); }); @@ -86,8 +85,8 @@ describe('ActionMenu', () => { render(); fireEvent.click(screen.getByText('Actions')); - expect(screen.getByText('Edit resource')).toBeVisible(); - expect(screen.getByText('Group2')).toBeVisible(); - expect(screen.getByText('External Link')).toBeVisible(); + expect(screen.getByText('Edit resource')).toBeInTheDocument(); + expect(screen.getByText('Group2')).toBeInTheDocument(); + expect(screen.getByText('External Link')).toBeInTheDocument(); }); }); diff --git a/packages/module/src/DetailsPageHeader/DetailsPageHeader.test.tsx b/packages/module/src/DetailsPageHeader/DetailsPageHeader.test.tsx index b3e98590..d999a7f6 100644 --- a/packages/module/src/DetailsPageHeader/DetailsPageHeader.test.tsx +++ b/packages/module/src/DetailsPageHeader/DetailsPageHeader.test.tsx @@ -49,8 +49,7 @@ describe('DetailsPageHeader', () => { render(detailsPageHeaderJSX(mockProps)); // Breadcrumbs - expect(screen.getByText('Resources')).toBeVisible(); - expect(screen.getByText('Resource details')).toBeVisible(); + expect(screen.getByText('Some breadcrumbs')).toBeVisible(); // Page heading expect(screen.getByText('example-resource')).toBeVisible(); // Action buttons @@ -58,19 +57,12 @@ describe('DetailsPageHeader', () => { // Action menu expect(screen.getByText('Actions')).toBeVisible(); }); - test('Clicking on breadcrumb triggers specified path', () => { - render(detailsPageHeaderJSX(mockProps)); - - // Click Workspaces link - fireEvent.click(screen.getByTestId('breadcrumb-link-0')); - expect(screen.getByText('Resource list page')).toBeVisible(); - }); test('Clicking on actions menu reveals menu options', () => { render(detailsPageHeaderJSX(mockProps)); fireEvent.click(screen.getByText('Actions')); - expect(screen.getByText('Edit resource')).toBeVisible(); - expect(screen.getByText('Delete resource')).toBeVisible(); + expect(screen.getByText('Edit resource')).toBeInTheDocument(); + expect(screen.getByText('Delete resource')).toBeInTheDocument(); }); test('Action button triggers callback', () => { render(detailsPageHeaderJSX(mockProps));