Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update v6 alphas #54

Merged
merged 2 commits into from
May 3, 2024
Merged

update v6 alphas #54

merged 2 commits into from
May 3, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Apr 15, 2024

Closes #46.

  • Updates to latest v6 alpha versions
  • Fixes EmptyState structure change - as there was no header text, body text was pulled up into the title
  • Updates usages of v5 to v6 classes (pf-v6-c-console__xterm doesn't seem to exist, did we have a v5 for this or was it always just a placeholder? @mcoker)
  • Updates build commands to include watch
  • Updates snapshots

@kmcfaul kmcfaul linked an issue Apr 15, 2024 that may be closed by this pull request
react-console: Consume v6 alphas and build Penta demo #46
Closed
2 tasks
@mcoker
Copy link

mcoker commented Apr 15, 2024

Updates usages of v5 to v6 classes (pf-v6-c-console__xterm doesn't seem to exist, did we have a v5 for this or was it always just a placeholder? @mcoker)

That class doesn't come from core - there are no *-c-console* classes/vars/etc

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Apr 16, 2024

They must come directly from react-styles then, will take a look.

@dlabaj dlabaj assigned dlabaj and kmcfaul and unassigned dlabaj Apr 16, 2024
@dlabaj dlabaj added the breaking change 💥 this change requires a major release and has API changes. label Apr 16, 2024
@dlabaj
Copy link
Contributor

dlabaj commented Apr 16, 2024

@kmcfaul Can you do post the Patternfly document to surge and include it in this PR so design can see the updates.

@dlabaj dlabaj requested a review from mcoker April 16, 2024 17:41
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Apr 17, 2024

Here is the surge - https://windy-clocks-47747.surge.sh/

nicolethoen
nicolethoen approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, the console is behaving the same way in your preview that it does on patternfly.org right now.

I know react-console has some styles which are defined and live in @patternfly/react-styles, so we should open a follow up issue for this PR to make sure those are all using the tokens correctly (and then an additional follow up here to consume the latest react-styles version).

But i don't see anything here IMO that would block this from merging as an alpha :)

andrew-ronaldson
andrew-ronaldson approved these changes Apr 26, 2024
View reviewed changes
Copy link

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. thanks!

dlabaj
dlabaj approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlabaj dlabaj merged commit ed317dc into patternfly:v6 May 3, 2024
7 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlabaj dlabaj dlabaj approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@mcoker mcoker Awaiting requested review from mcoker

Assignees

@kmcfaul kmcfaul

Labels
breaking change 💥 this change requires a major release and has API changes. needs css review needs design review released on @prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-console: Consume v6 alphas and build Penta demo
6 participants
@kmcfaul @mcoker @dlabaj @wise-king-sullyman @nicolethoen @andrew-ronaldson