From 280ca91f1db1ae594a5ff5a5605deff71c40e436 Mon Sep 17 00:00:00 2001
From: Jeff Phillips <jephilli@redhat.com>
Date: Fri, 7 Jun 2024 15:42:55 -0400
Subject: [PATCH] feat(group labels): Add ability to show group labels on hover
 (#214)

---
 .../pipelineGroupsDemo/DemoTaskGroup.tsx      | 43 ++++-----
 .../demos/topologyPackageDemo/DemoGroup.tsx   |  1 +
 .../src/components/groups/DefaultGroup.tsx    |  2 +
 .../groups/DefaultGroupExpanded.tsx           | 80 +++++++++--------
 .../components/groups/DefaultTaskGroup.tsx    |  2 +
 .../groups/DefaultTaskGroupExpanded.tsx       | 89 +++++++++++--------
 6 files changed, 119 insertions(+), 98 deletions(-)

diff --git a/packages/demo-app-ts/src/demos/pipelineGroupsDemo/DemoTaskGroup.tsx b/packages/demo-app-ts/src/demos/pipelineGroupsDemo/DemoTaskGroup.tsx
index 348f1827..330e7f50 100644
--- a/packages/demo-app-ts/src/demos/pipelineGroupsDemo/DemoTaskGroup.tsx
+++ b/packages/demo-app-ts/src/demos/pipelineGroupsDemo/DemoTaskGroup.tsx
@@ -12,10 +12,6 @@ import {
   EdgeCreationTypes,
   useHover,
   ScaleDetailsLevel,
-  DEFAULT_LAYER,
-  Layer,
-  TOP_LAYER,
-  GROUPS_LAYER,
   RunStatus
 } from '@patternfly/react-topology';
 import { DEFAULT_TASK_HEIGHT, GROUP_TASK_WIDTH } from './createDemoPipelineGroupsNodes';
@@ -38,29 +34,26 @@ const DemoTaskGroup: React.FunctionComponent<DemoTaskGroupProps> = ({ element, .
   if (!isNode(element)) {
     return null;
   }
-  const groupLayer = element.isCollapsed() ? DEFAULT_LAYER : GROUPS_LAYER;
 
   return (
-    <Layer id={detailsLevel !== ScaleDetailsLevel.high && hover ? TOP_LAYER : groupLayer}>
-      <g ref={hoverRef}>
-        <DefaultTaskGroup
-          labelPosition={verticalLayout ? LabelPosition.top : LabelPosition.bottom}
-          collapsible
-          collapsedWidth={GROUP_TASK_WIDTH}
-          collapsedHeight={DEFAULT_TASK_HEIGHT}
-          element={element as Node}
-          recreateLayoutOnCollapseChange
-          getEdgeCreationTypes={getEdgeCreationTypes}
-          scaleNode={hover && detailsLevel !== ScaleDetailsLevel.high}
-          showLabel={detailsLevel === ScaleDetailsLevel.high}
-          hideDetailsAtMedium
-          showStatusState
-          status={data.status}
-          hiddenDetailsShownStatuses={[RunStatus.Succeeded]}
-          {...rest}
-        />
-      </g>
-    </Layer>
+    <g id="group-hover-ref" ref={hoverRef}>
+      <DefaultTaskGroup
+        labelPosition={verticalLayout ? LabelPosition.top : LabelPosition.bottom}
+        collapsible
+        collapsedWidth={GROUP_TASK_WIDTH}
+        collapsedHeight={DEFAULT_TASK_HEIGHT}
+        element={element as Node}
+        recreateLayoutOnCollapseChange
+        getEdgeCreationTypes={getEdgeCreationTypes}
+        scaleNode={hover && detailsLevel !== ScaleDetailsLevel.high}
+        showLabelOnHover
+        hideDetailsAtMedium
+        showStatusState
+        status={data.status}
+        hiddenDetailsShownStatuses={[RunStatus.Succeeded]}
+        {...rest}
+      />
+    </g>
   );
 };
 
diff --git a/packages/demo-app-ts/src/demos/topologyPackageDemo/DemoGroup.tsx b/packages/demo-app-ts/src/demos/topologyPackageDemo/DemoGroup.tsx
index bc6b0dbe..7116ccc7 100644
--- a/packages/demo-app-ts/src/demos/topologyPackageDemo/DemoGroup.tsx
+++ b/packages/demo-app-ts/src/demos/topologyPackageDemo/DemoGroup.tsx
@@ -58,6 +58,7 @@ const DemoGroup: React.FunctionComponent<DemoGroupProps> = ({ element, onContext
       collapsedHeight={DEFAULT_NODE_SIZE}
       showLabel={detailsLevel === ScaleDetailsLevel.high}
       hulledOutline={options.hulledOutline}
+      showLabelOnHover
     >
       {groupElement.isCollapsed() ? renderIcon() : null}
     </DefaultGroup>
diff --git a/packages/module/src/components/groups/DefaultGroup.tsx b/packages/module/src/components/groups/DefaultGroup.tsx
index 0108e913..c0633cae 100644
--- a/packages/module/src/components/groups/DefaultGroup.tsx
+++ b/packages/module/src/components/groups/DefaultGroup.tsx
@@ -32,6 +32,8 @@ interface DefaultGroupProps {
   secondaryLabel?: string;
   /** Flag to show the label */
   showLabel?: boolean; // Defaults to true
+  /** Flag to show the label when hovering (effects expanded only) */
+  showLabelOnHover?: boolean;
   /** Position of the label, top or bottom. Defaults to element.getLabelPosition() or bottom */
   labelPosition?: LabelPosition;
   /** The maximum length of the label before truncation */
diff --git a/packages/module/src/components/groups/DefaultGroupExpanded.tsx b/packages/module/src/components/groups/DefaultGroupExpanded.tsx
index ce4e4c07..39e7d2a1 100644
--- a/packages/module/src/components/groups/DefaultGroupExpanded.tsx
+++ b/packages/module/src/components/groups/DefaultGroupExpanded.tsx
@@ -31,6 +31,7 @@ type DefaultGroupExpandedProps = {
   label?: string; // Defaults to element.getLabel()
   secondaryLabel?: string;
   showLabel?: boolean; // Defaults to true
+  showLabelOnHover?: boolean;
   truncateLength?: number; // Defaults to 13
   badge?: string;
   badgeColor?: string;
@@ -119,6 +120,7 @@ const DefaultGroupExpanded: React.FunctionComponent<DefaultGroupExpandedProps> =
   label,
   secondaryLabel,
   showLabel = true,
+  showLabelOnHover,
   truncateLength,
   dndDropRef,
   droppable,
@@ -141,11 +143,11 @@ const DefaultGroupExpanded: React.FunctionComponent<DefaultGroupExpandedProps> =
   onCollapseChange,
   hulledOutline = true
 }) => {
-  const [hovered, hoverRef] = useHover();
-  const [labelHover, labelHoverRef] = useHover();
+  const [hovered, hoverRef] = useHover(200, 500);
+  const [labelHover, labelHoverRef] = useHover(0);
   const dragLabelRef = useDragNode()[1];
   const refs = useCombineRefs<SVGPathElement>(hoverRef, dragNodeRef);
-  const isHover = hover !== undefined ? hover : hovered;
+  const isHover = hover !== undefined ? hover : hovered || labelHover;
   const anchorRef = useSvgAnchor();
   const outlineRef = useCombineRefs(dndDropRef, anchorRef);
   const labelLocation = React.useRef<PointWithSize>();
@@ -239,8 +241,46 @@ const DefaultGroupExpanded: React.FunctionComponent<DefaultGroupExpandedProps> =
       ? labelLocation.current[1] - outlinePadding - labelGap * 2
       : labelLocation.current[1] + outlinePadding + labelGap;
 
+  const scale = element.getGraph().getScale();
+  const medScale = element.getGraph().getDetailsLevelThresholds().medium;
+  const labelScale = !showLabel && showLabelOnHover && isHover ? Math.min(1 / scale, 1 / medScale) : 1;
+  const labelPositionScale = 1 / labelScale;
+
+  const groupLabel =
+    (showLabel || (showLabelOnHover && isHover)) && (label || element.getLabel()) ? (
+      <g ref={labelHoverRef} transform={isHover ? `scale(${labelScale})` : undefined}>
+        <NodeLabel
+          className={styles.topologyGroupLabel}
+          x={startX * labelPositionScale}
+          y={startY * labelPositionScale}
+          paddingX={8}
+          paddingY={5}
+          dragRef={dragNodeRef ? dragLabelRef : undefined}
+          status={element.getNodeStatus()}
+          secondaryLabel={secondaryLabel}
+          truncateLength={truncateLength}
+          badge={badge}
+          badgeColor={badgeColor}
+          badgeTextColor={badgeTextColor}
+          badgeBorderColor={badgeBorderColor}
+          badgeClassName={badgeClassName}
+          badgeLocation={badgeLocation}
+          labelIconClass={labelIconClass}
+          labelIcon={labelIcon}
+          labelIconPadding={labelIconPadding}
+          onContextMenu={onContextMenu}
+          contextMenuOpen={contextMenuOpen}
+          hover={isHover || labelHover}
+          actionIcon={collapsible ? <CollapseIcon /> : undefined}
+          onActionIconClick={() => onCollapseChange(element, true)}
+        >
+          {label || element.getLabel()}
+        </NodeLabel>
+      </g>
+    ) : null;
+
   return (
-    <g ref={labelHoverRef} onContextMenu={onContextMenu} onClick={onSelect} className={groupClassName}>
+    <g onContextMenu={onContextMenu} onClick={onSelect} className={groupClassName}>
       <Layer id={GROUPS_LAYER}>
         <g ref={refs} onContextMenu={onContextMenu} onClick={onSelect} className={innerGroupClassName}>
           {hulledOutline ? (
@@ -256,38 +296,8 @@ const DefaultGroupExpanded: React.FunctionComponent<DefaultGroupExpandedProps> =
             />
           )}
         </g>
+        {groupLabel && isHover ? <Layer id={TOP_LAYER}>{groupLabel}</Layer> : groupLabel}
       </Layer>
-      {showLabel && (label || element.getLabel()) && (
-        <Layer id={isHover ? TOP_LAYER : undefined}>
-          <NodeLabel
-            className={styles.topologyGroupLabel}
-            x={startX}
-            y={startY}
-            paddingX={8}
-            paddingY={5}
-            dragRef={dragNodeRef ? dragLabelRef : undefined}
-            status={element.getNodeStatus()}
-            secondaryLabel={secondaryLabel}
-            truncateLength={truncateLength}
-            badge={badge}
-            badgeColor={badgeColor}
-            badgeTextColor={badgeTextColor}
-            badgeBorderColor={badgeBorderColor}
-            badgeClassName={badgeClassName}
-            badgeLocation={badgeLocation}
-            labelIconClass={labelIconClass}
-            labelIcon={labelIcon}
-            labelIconPadding={labelIconPadding}
-            onContextMenu={onContextMenu}
-            contextMenuOpen={contextMenuOpen}
-            hover={isHover || labelHover}
-            actionIcon={collapsible ? <CollapseIcon /> : undefined}
-            onActionIconClick={() => onCollapseChange(element, true)}
-          >
-            {label || element.getLabel()}
-          </NodeLabel>
-        </Layer>
-      )}
     </g>
   );
 };
diff --git a/packages/module/src/pipelines/components/groups/DefaultTaskGroup.tsx b/packages/module/src/pipelines/components/groups/DefaultTaskGroup.tsx
index 41f323f9..d55647c9 100644
--- a/packages/module/src/pipelines/components/groups/DefaultTaskGroup.tsx
+++ b/packages/module/src/pipelines/components/groups/DefaultTaskGroup.tsx
@@ -46,6 +46,8 @@ export interface DefaultTaskGroupProps {
   scaleNode?: boolean;
   /** Flag to hide details at medium scale */
   hideDetailsAtMedium?: boolean;
+  /** Flag to show the label when hovering and details are hidden (effects expanded only) */
+  showLabelOnHover?: boolean;
   /** Flag if the user is hovering on the node */
   hover?: boolean;
   /** Label for the node. Defaults to element.getLabel() */
diff --git a/packages/module/src/pipelines/components/groups/DefaultTaskGroupExpanded.tsx b/packages/module/src/pipelines/components/groups/DefaultTaskGroupExpanded.tsx
index 45baefd4..5fbc37a5 100644
--- a/packages/module/src/pipelines/components/groups/DefaultTaskGroupExpanded.tsx
+++ b/packages/module/src/pipelines/components/groups/DefaultTaskGroupExpanded.tsx
@@ -7,7 +7,7 @@ import NodeLabel from '../../../components/nodes/labels/NodeLabel';
 import { Layer } from '../../../components/layers';
 import { GROUPS_LAYER, TOP_LAYER } from '../../../const';
 import { maxPadding, useCombineRefs, useHover } from '../../../utils';
-import { AnchorEnd, isGraph, LabelPosition, Node, NodeStyle } from '../../../types';
+import { AnchorEnd, isGraph, LabelPosition, Node, NodeStyle, ScaleDetailsLevel } from '../../../types';
 import { useAnchor, useDragNode } from '../../../behavior';
 import { DagreLayoutOptions, TOP_TO_BOTTOM } from '../../../layouts';
 import TaskGroupSourceAnchor from '../anchors/TaskGroupSourceAnchor';
@@ -26,6 +26,8 @@ const DefaultTaskGroupExpanded: React.FunctionComponent<Omit<DefaultTaskGroupPro
       label,
       secondaryLabel,
       showLabel = true,
+      showLabelOnHover,
+      hideDetailsAtMedium,
       truncateLength,
       canDrop,
       dropTarget,
@@ -46,14 +48,15 @@ const DefaultTaskGroupExpanded: React.FunctionComponent<Omit<DefaultTaskGroupPro
       onCollapseChange,
       labelPosition
     }) => {
-      const [hovered, hoverRef] = useHover();
-      const [labelHover, labelHoverRef] = useHover();
+      const [hovered, hoverRef] = useHover(200, 500);
+      const [labelHover, labelHoverRef] = useHover(0);
       const dragLabelRef = useDragNode()[1];
       const refs = useCombineRefs<SVGPathElement>(hoverRef, dragNodeRef);
-      const isHover = hover !== undefined ? hover : hovered;
+      const isHover = hover !== undefined ? hover : hovered || labelHover;
       const verticalLayout = (element.getGraph().getLayoutOptions?.() as DagreLayoutOptions)?.rankdir === TOP_TO_BOTTOM;
       const groupLabelPosition = labelPosition ?? element.getLabelPosition() ?? LabelPosition.bottom;
       let parent = element.getParent();
+      const detailsLevel = element.getGraph().getDetailsLevel();
       let altGroup = false;
       while (!isGraph(parent)) {
         altGroup = !altGroup;
@@ -121,12 +124,53 @@ const DefaultTaskGroupExpanded: React.FunctionComponent<Omit<DefaultTaskGroupPro
         canDrop && 'pf-m-highlight',
         dragging && 'pf-m-dragging',
         selected && 'pf-m-selected',
-        (isHover || labelHover) && 'pf-m-hover',
+        isHover && 'pf-m-hover',
         canDrop && dropTarget && 'pf-m-drop-target'
       );
 
+      const scale = element.getGraph().getScale();
+      const medScale = element.getGraph().getDetailsLevelThresholds().medium;
+      const labelScale = detailsLevel !== ScaleDetailsLevel.high ? Math.min(1 / scale, 1 / medScale) : 1;
+      const labelPositionScale = detailsLevel !== ScaleDetailsLevel.high ? 1 / labelScale : 1;
+
+      const groupLabel =
+        showLabel &&
+        (!hideDetailsAtMedium || detailsLevel === ScaleDetailsLevel.high || (isHover && showLabelOnHover)) &&
+        (label || element.getLabel()) ? (
+          <g ref={labelHoverRef} transform={isHover ? `scale(${labelScale})` : undefined}>
+            <NodeLabel
+              className={styles.topologyGroupLabel}
+              x={labelX * labelPositionScale}
+              y={labelY * labelPositionScale}
+              position={labelPosition}
+              paddingX={8}
+              paddingY={5}
+              dragRef={dragNodeRef ? dragLabelRef : undefined}
+              status={element.getNodeStatus()}
+              secondaryLabel={secondaryLabel}
+              truncateLength={truncateLength}
+              badge={badge}
+              badgeColor={badgeColor}
+              badgeTextColor={badgeTextColor}
+              badgeBorderColor={badgeBorderColor}
+              badgeClassName={badgeClassName}
+              badgeLocation={badgeLocation}
+              labelIconClass={labelIconClass}
+              labelIcon={labelIcon}
+              labelIconPadding={labelIconPadding}
+              onContextMenu={onContextMenu}
+              contextMenuOpen={contextMenuOpen}
+              hover={isHover}
+              actionIcon={collapsible ? <CollapseIcon /> : undefined}
+              onActionIconClick={() => onCollapseChange(element, true)}
+            >
+              {label || element.getLabel()}
+            </NodeLabel>
+          </g>
+        ) : null;
+
       return (
-        <g ref={labelHoverRef} onContextMenu={onContextMenu} onClick={onSelect} className={groupClassName}>
+        <g onContextMenu={onContextMenu} onClick={onSelect} className={groupClassName}>
           <Layer id={GROUPS_LAYER}>
             <g ref={refs} onContextMenu={onContextMenu} onClick={onSelect} className={innerGroupClassName}>
               <rect
@@ -137,39 +181,8 @@ const DefaultTaskGroupExpanded: React.FunctionComponent<Omit<DefaultTaskGroupPro
                 className={styles.topologyGroupBackground}
               />
             </g>
+            {groupLabel && isHover ? <Layer id={TOP_LAYER}>{groupLabel}</Layer> : groupLabel}
           </Layer>
-          {showLabel && (label || element.getLabel()) && (
-            <Layer id={isHover ? TOP_LAYER : undefined}>
-              <NodeLabel
-                className={styles.topologyGroupLabel}
-                x={labelX}
-                y={labelY}
-                position={labelPosition}
-                paddingX={8}
-                paddingY={5}
-                dragRef={dragNodeRef ? dragLabelRef : undefined}
-                status={element.getNodeStatus()}
-                secondaryLabel={secondaryLabel}
-                truncateLength={truncateLength}
-                badge={badge}
-                badgeColor={badgeColor}
-                badgeTextColor={badgeTextColor}
-                badgeBorderColor={badgeBorderColor}
-                badgeClassName={badgeClassName}
-                badgeLocation={badgeLocation}
-                labelIconClass={labelIconClass}
-                labelIcon={labelIcon}
-                labelIconPadding={labelIconPadding}
-                onContextMenu={onContextMenu}
-                contextMenuOpen={contextMenuOpen}
-                hover={isHover || labelHover}
-                actionIcon={collapsible ? <CollapseIcon /> : undefined}
-                onActionIconClick={() => onCollapseChange(element, true)}
-              >
-                {label || element.getLabel()}
-              </NodeLabel>
-            </Layer>
-          )}
         </g>
       );
     }