Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RTL support #116

Open
Tracked by #65
srambach opened this issue Oct 30, 2023 · 4 comments
Open
Tracked by #65

Implement RTL support #116

srambach opened this issue Oct 30, 2023 · 4 comments
Assignees
@jeff-phillips-18
Milestone
Prioritized Backlog

Comments

@srambach
Copy link
Member

Describe the problem
PatternFly now provides RTL language support, but topology has a few instances where it's causing problems. Node labels are one trouble spot.

How do you reproduce the problem?
Add dir="rtl" to the <body> tag to see it in RTL. Note that English text will still be readable left to right, but should be right aligned where it was previously left aligned, etc.

Screenshots
image

Any other information?
See the RTL handbook for help - in particular, the helper multiplier might be of use. https://www.patternfly.org/developer-resources/right-to-left-handbook#patternfly-rtl-helpers
@srambach srambach mentioned this issue Oct 30, 2023
Closed
@jessiehuff jessiehuff added this to the 2023.11 - 11/30 milestone Oct 30, 2023
@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Jan 9, 2024 •
edited
Loading

@srambach Would RTL expect node label elements to be completely reversed?

LTR: <Icon> <Badge> <Label> <Context Menu>

image

Should RTL be: <Context Menu> <Label> <Badge> <Icon>?

@jeff-phillips-18
Copy link
Member

@andrew-ronaldson ^^

@srambach
Copy link
Member Author

@jeff-phillips-18 Yes - I think those elements would be reversed in position as you list. Just FYI to clarify, unless you actually translate the text into an RTL language, though, the words themselves will read left to right. But yes, I'd expect the elements to reverse to be <Context Menu> <Label> <Badge> <Icon>.

@andrew-ronaldson
Copy link
Collaborator

What @srambach said! Thanks Sarah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
None yet
Projects
PatternFly Issues
Status: Backlog
Milestone
Prioritized Backlog
Development

No branches or pull requests
4 participants
@jeff-phillips-18 @srambach @jessiehuff @andrew-ronaldson