Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology: Convex algorithm for nodes of different sizes looks weird #14

Open
jeff-phillips-18 opened this issue Apr 5, 2023 · 0 comments

Comments

@jeff-phillips-18
Copy link
Member

Describe the issue. What is the expected and unexpected behavior?
The hull algorithm used to draw the outline of or groups on topology was built to support nodes of the same size. It identifies the point of the node and then adds padding. If all nodes are the same size, the tangent lines between nodes always intersect the circle outline of the nodes where a 90 degree angle could be formed that goes to the center of the node.

This however doesn't work with nodes of different sizes are shown here:

image

Another example:

image

Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.

n/a

Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
More a bug, but also an enhancement 😏

What is your product and what release version are you targeting?
OpenShift Developer Console, this is a known issue since 4.6, and was reported initially as ODC-2071, but since the code was extracted into @patternfly/react-topology we believe we should follow up this issue here.

/cc @jerolimov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants