Client dependency updates, move to TypeScript #47
Conversation
neodescis
changed the title
…od/dev mode to be based off of NODE_ENV
|
K, I think the PR is ready. Let me know if you see anything that needs attention. I managed to get bootstrap-loader working again. Apparently switching to TypeScript broke HMR, so I got that working again last night. |
| ); | ||
|
|
||
| // Server .NET Core | ||
| gulp.task('restore-dotnet-packages', () => |
There was a problem hiding this comment.
@neodescis, I don't think the gulpfile should be responsible for the dotnet stuff. We could update the csproject to hook up to the Build/Clean targets to run related gulp tasks, but the over-arching build process of dotnet should be left up to the implementation (wether they use Cake, dotnet-script, make, etc).
Can you remove this?
There was a problem hiding this comment.
@pauldotknopf, I can take it out if you like; I like gulp for orchestrating, so this is how I've been running things for development. Perhaps more importantly though, if I remove this, then the webpack dev middleware and HMR go with it, since they are tied into browsersync and its proxy to the dotnet server. You sure you want me to take it out? Up to you.
|
I finally got around to look at this, and I am very thankful! You did a lot of amazing work. Once it's merged, I'll give you a by-line. I'd love to buy you a beer. Got a PayPal? Email it to me, if you like. |
|
Ha, not a problem, it's been my pleasure. Glad to give back! You've done really excellent work yourself, especially with the underlying view engine. I'm happy to accept a beer. I appreciate the gesture; I definitely wasn't expecting anything in return :-) |
Done:
Still to be done:
resolves #38 resolves #39 resolves #31