-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various dependency updates #45
Comments
Wow. I would love a PR that has these things. As you could tell, I haven't had time to keep dependencies update. Node packages change very often. As for TypeScript, I'm also on board. I'll never write a new project without it. How much is in TypeScript? Even the jsx/React stuff? |
I have both of my sites now converted fully to .ts and .tsx TypeScript files, complete with noImplicitAny turned on. I'll get to work on a PR. It might take me a couple of weeks; I've been updating my projects incrementally, so I'm exactly not sure how long it'll take me to back-port the changes to this codebase. I'll try to post updates here. Also, there are two additional caveats I should mention:
|
Looks like I spoke too soon about bootstrap-loader; there is a new PR there for webpack 4 support. So hopefully I'll be able to switch that back. |
First update on my PR: I got the server side of things updated to .NET Core 2.0, including the identity stuff. The PR will be for master, and once that's in we can push relevant changes to the empty-template branch. |
Roger that. I can do this in small chunks if you want to submit now, if you like. Your call. |
Ha, thanks for merging the server side! That was fast :-) I'm thinking it might make sense to do the client side in one go, as I don't know how useful any changes would be until I'm all the way through. |
I agree. |
Thought I'd give an update. What's done so far (and pushed to my fork):
What's remaining:
After I finish up those last two, I'll submit a pull request! |
Hey, sorry I didn't get back to you. I'm still excited for your changes. This project needs a breath of new/fresh air. Again, I'm aboard with all your notes/comments. Thanks again! |
Not a problem. I've made good progress and should have a PR for you soon. |
PR created! Once that's in, I can work on getting the changes pushed out to the empty-template branch (which is what I used as the starting point for my own projects). |
Apparently bootstrap-loader has a beta release to work with Webpack 4. It's not quite as simple as swapping it out (need to have separate loaders defined for prod and dev), but I'll try to get a PR together for that before I move on to empty-template. |
Figured out the new bootstrap-loader. I just added it to my current PR. |
First off, thank you Paul for providing this template. I have two web sites that I've built off of this, and it's worked out great. Since I started up these sites, I've made a bunch of updates, and I thought I'd offer a hand to get them updated here. I'd be happy to work on a pull request, but I wanted to see what all you'd like me to incorporate. Here's a list of what I've changed/updated:
Let me know what you think, and if you'd be interested incorporating some or all of this. Then I can start working on a pull request.
The text was updated successfully, but these errors were encountered: