Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual C++ 14 can no longer build since upgrade of pdfium #27

Open
redturtlepower opened this issue Jul 17, 2018 · 2 comments
Open

Visual C++ 14 can no longer build since upgrade of pdfium #27

redturtlepower opened this issue Jul 17, 2018 · 2 comments

Comments

@redturtlepower
Copy link

redturtlepower commented Jul 17, 2018

The commit b69b17b does not compile on my Windows 8.1 machine, with MSVC 14 (it is the only commit I have tested).

Seems to be the same issue that Pinaraf had last year:

fx_memory.h:
C2065: noinline undeclared identifier
C4430: missing type specifier
C3861: FX_OutOfMemoryTerminate identifier not found
C2448: attribute function-style initializer appears to be a specific function definition

fx_stream.h:
C1083: Cannot open include file: 'dirent.h'. No such file or directory

I have opened the project file in QtCreator and tried to run the 'cpp' target.

@paulovap
Copy link
Owner

Hi @redturtlepower! Unfortunately, I don't have a Windows machine to test it out, it would be lovely to get a patch for that issue you are facing.

@redturtlepower
Copy link
Author

After some analysis I can tell that the macro '&& defined (Q_CC_MSVC)' does not work. I needed to manually define it in the top level pri file, and this is certainly not intended. You could perhaps instead #include <qglobal.h> somewhere. Moreover you seem to be missing the #include <windows.h> for HANDLE and so on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants