Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the workflow of copying one or multiple geomarks #41

Open
gregseb opened this issue Jan 2, 2018 · 1 comment
Open

Improve the workflow of copying one or multiple geomarks #41

gregseb opened this issue Jan 2, 2018 · 1 comment
Milestone

Comments

@gregseb
Copy link
Member

gregseb commented Jan 2, 2018

We should try to improve the workflow of copying geomarks a little better.

When calling gm.copy() on an existing Geomark it works as expected. Adding additional urls however... gm.copy(geomarkUrl=['...', ...]) should append those additional urls to the one that was already used to create the gm Geomark object rather than overriding it.

Additionally there should be a way to simply call Geomark.copy([...]) with a list of GeomarkUrls or even perhaps with a list of Geomark objects without having to first create a Geomark object with one of the Geomark IDs.

@gregseb gregseb added this to the 1.0 release milestone Jan 2, 2018
@spatialbits
Copy link
Member

spatialbits commented Jan 2, 2018

Yep, part 1 of this definitely needs doing and shouldn't require much work. I also suspect that the Geomark server is smart enough to strip off repeated IDs, so we could easily just stick the self.id in the list every time.

Part 2 - copy actually already works exactly as you're suggesting it should :D. It will take URLs or IDs. We could take it a little further and allow a list of Geomark objects and test for that in the copy method; it would deviate from the Geomark API though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants