You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should try to improve the workflow of copying geomarks a little better.
When calling gm.copy() on an existing Geomark it works as expected. Adding additional urls however... gm.copy(geomarkUrl=['...', ...]) should append those additional urls to the one that was already used to create the gm Geomark object rather than overriding it.
Additionally there should be a way to simply call Geomark.copy([...]) with a list of GeomarkUrls or even perhaps with a list of Geomark objects without having to first create a Geomark object with one of the Geomark IDs.
The text was updated successfully, but these errors were encountered:
Yep, part 1 of this definitely needs doing and shouldn't require much work. I also suspect that the Geomark server is smart enough to strip off repeated IDs, so we could easily just stick the self.id in the list every time.
Part 2 - copy actually already works exactly as you're suggesting it should :D. It will take URLs or IDs. We could take it a little further and allow a list of Geomark objects and test for that in the copy method; it would deviate from the Geomark API though.
We should try to improve the workflow of copying geomarks a little better.
When calling gm.copy() on an existing Geomark it works as expected. Adding additional urls however...
gm.copy(geomarkUrl=['...', ...])
should append those additional urls to the one that was already used to create thegm
Geomark object rather than overriding it.Additionally there should be a way to simply call Geomark.copy([...]) with a list of GeomarkUrls or even perhaps with a list of Geomark objects without having to first create a Geomark object with one of the Geomark IDs.
The text was updated successfully, but these errors were encountered: