is_positive returns true for 0

[robinsdan]

[Tony-Samuels]

is_positive has been deprecated since before 1.0, and is_sign_positive does what it says on the tin, it just checks the sign bit.

[Tony-Samuels]

Hmm, we do implement the Signed trait incorrectly though, now I'm checking it. That does look like a bug. I'm not sure if that's what you're referring to, though?