-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate transform_default #56
Comments
Any comments on this? Otherwise, I'd start with first steps to deprecate it. |
It was useful when providing a callable as default, and actually calling it to get the default value at runtime, though if nobody's using I'm OK to deprecate it. |
The idea is to transform the default always, unless the |
Ah yes, I forgot that. Then it was useful when you wanted to transform the value returned by the callable as well haha. But then the callable could indeed directly return the final value, so it's not that useful. |
I'm okay with that, but it should be noted that |
Seems I will need to solve #37 first. |
I don't really see the point in the
transform_default
argument. It seems quite straightforward to provide the default value the same way it should be set up in settings. I'm in favor of deprecating thetransform_default
and eventually removing it and transform the default in all cases.The text was updated successfully, but these errors were encountered: