Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal setting validation #95

Open
ziima opened this issue Nov 10, 2020 · 0 comments
Open

Refactor internal setting validation #95

ziima opened this issue Nov 10, 2020 · 0 comments

Comments

@ziima
Copy link
Collaborator

ziima commented Nov 10, 2020

Trying to implement a MappingSetting (#94), we encountered a problems with validation of a custom nested settings. Current implementation relies on exceptions for NestedListSetting and NestedDictSetting in Setting.raw_value.

We need to refactor the validation or the value extraction to support nested settings in general. One of the main problems is that we can't pass a setting value or its part to a nested setting instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant