Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom docker socket (Issue #386 ) #396

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Klubas
Copy link

@Klubas Klubas commented Nov 3, 2022

Add the possibility to use the environment variable DOCKER_SOCKET to set the docker socket path.
Useful if not using the official docker engine to run the containers.

Original issue:
#386

@Klubas Klubas marked this pull request as draft November 8, 2022 15:38
@Klubas
Copy link
Author

Klubas commented Nov 8, 2022

After thinking a bit more about it, and since flame is usually not configured using envionment variable, I changed this pull request to add a "dockerSocket" field in docker settings. Now you can change the socket path in the UI.

@Klubas Klubas marked this pull request as ready for review November 8, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant