Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req.locale type definition does not include 'all' #10244

Open
cbratschi opened this issue Dec 30, 2024 · 0 comments
Open

req.locale type definition does not include 'all' #10244

cbratschi opened this issue Dec 30, 2024 · 0 comments
Assignees

Comments

@cbratschi
Copy link

Describe the Bug

If a query get all locales using the 'all' value for locales, the req.locale value is 'all' but the type definition only contains the available locales.

See:

https://github.com/payloadcms/payload/blob/main/packages/payload/src/types/index.ts#L33

The type should be TypedLocale | 'all'.

Link to the code that reproduces this issue

https://github.com/cbratschi/payload

Reproduction Steps

Query a collection with locale set to 'all'. Violates type definition.

Which area(s) are affected? (Select all that apply)

area: core

Environment Info

Binaries:
  Node: 22.12.0
  npm: 10.9.0
  Yarn: 1.22.22
  pnpm: N/A
Relevant Packages:
  payload: 3.12.0
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:05:23 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6031
  Available memory (MB): 65536
  Available CPU cores: 16

PS: could someone extend this tools to support npm packages in monorepos? It can't find the Payload packages in the sub package.
@cbratschi cbratschi added status: needs-triage Possible bug which hasn't been reproduced yet validate-reproduction labels Dec 30, 2024
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants