fix(ui): disable save button until the upload file is uploaded / ready#10083
Merged
PatrikKozak merged 18 commits intomainfrom Jan 2, 2025
Merged
fix(ui): disable save button until the upload file is uploaded / ready#10083PatrikKozak merged 18 commits intomainfrom
PatrikKozak merged 18 commits intomainfrom
Conversation
…t to the Submit button
…-from-url-disabled-save
…-from-url-disabled-save
PatrikKozak
requested review from
DanRibbens,
denolfe and
jmikrut
as code owners
…-from-url-disabled-save
…-from-url-disabled-save
…-from-url-disabled-save
PatrikKozak
changed the title
DanRibbens
requested changes
Dec 27, 2024
Contributor
DanRibbens
left a comment
DanRibbens
left a comment
There was a problem hiding this comment.
Is there a reason we wouldn't want to add the upload status to the existing DocumentInfoProvider? I don't see what we gain by adding another provider.
DanRibbens
requested changes
Dec 31, 2024
Contributor
DanRibbens
left a comment
DanRibbens
left a comment
There was a problem hiding this comment.
Rather than adding the same logic for disabled state, you should pass the forceDisabled prop down. That way custom components all continue to work without having to make this same exact change also.
DanRibbens
approved these changes
Jan 2, 2025
Contributor
|
🚀 This is included in version v3.14.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
#10083) ### What? Previously, while uploading a file - if the uploading process took a bit of time, users could still save the document prior to the upload fully completing. ### Why? During the uploading process - the save button should be disabled until the upload is complete to prevent premature saving of an upload document. ### How? Now, we keep track of the state of the upload in a provider and disable the save button until the file is fully uploaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Previously, while uploading a file - if the uploading process took a bit of time, users could still save the document prior to the upload fully completing.
Why?
During the uploading process - the save button should be disabled until the upload is complete to prevent premature saving of an upload document.
How?
Now, we keep track of the state of the upload in a provider and disable the save button until the file is fully uploaded.