Skip to content

Commit e5f0b0f

Browse files
committed
moved the server creation into our playwright config and out the github actions
1 parent e22bf6e commit e5f0b0f

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

.github/workflows/playwright.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ jobs:
1919
run: npm i
2020
- name: Install Playwright Browsers
2121
run: npx playwright install --with-deps
22-
23-
- name: Run server
24-
run: ./.github/scripts/runServerV2.sh
25-
2622
- name: Run Playwright tests
2723
run: npx playwright test
2824
- uses: actions/upload-artifact@v4

playwright.config.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ module.exports = defineConfig({
3737
}
3838
}
3939
],
40-
// webServer: [
41-
// {
42-
// command: 'npm run dev:ci',
43-
// url: 'http://127.0.0.1:8080',
44-
// timeout: 120 * 1000,
45-
// reuseExistingServer: !process.env.CI
46-
// }
47-
// ],
40+
webServer: [
41+
{
42+
command: './.github/scripts/runServerV2.sh',
43+
port: 8080,
44+
timeout: 120 * 1000,
45+
reuseExistingServer: !process.env.CI
46+
}
47+
],
4848
use: {
4949
/* Base URL to use in actions like `await page.goto('/')`. */
5050
baseURL: 'https://127.0.0.1:8080',

0 commit comments

Comments
 (0)