Wiretap crashing on invalid memory address

[fullstackmaverick]

I am getting the following error for hitting my endpoint via http://localhost:9090

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x68 pc=0x102e1e97c]

goroutine 1289 [running]:
github.com/santhosh-tekuri/jsonschema/v5.(*Schema).validateValue.func1()
        /home/runner/go/pkg/mod/github.com/santhosh-tekuri/jsonschema/v5@v5.3.1/schema.go:178 +0x120
panic({0x1038282a0?, 0x1040efad0?})
        /opt/hostedtoolcache/go/1.22.5/x64/src/runtime/panic.go:770 +0x124
github.com/santhosh-tekuri/jsonschema/v5.(*Schema).validate(0x0, {0x0, 0x0, 0x0}, 0x0, {0x0, 0x0}, {0x103818a00, 0x140004202a0}, {0x0, ...})
        /home/runner/go/pkg/mod/github.com/santhosh-tekuri/jsonschema/v5@v5.3.1/schema.go:253 +0x43c
github.com/santhosh-tekuri/jsonschema/v5.(*Schema).validateValue(0x0, {0x103818a00?, 0x140004202a0?}, {0x0, 0x0})
        /home/runner/go/pkg/mod/github.com/santhosh-tekuri/jsonschema/v5@v5.3.1/schema.go:182 +0x94
github.com/santhosh-tekuri/jsonschema/v5.(*Schema).Validate(...)
        /home/runner/go/pkg/mod/github.com/santhosh-tekuri/jsonschema/v5@v5.3.1/schema.go:168
github.com/pb33f/libopenapi-validator/responses.ValidateResponseSchema(0x140004d1680, 0x140000d6480, 0x140000f9b88, {0x14000958000, 0x1020, 0x1500}, {0x1400096a000, 0x8d4, 0x1400026c1d1?})
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.0.56/responses/validate_response.go:132 +0x99c
github.com/pb33f/libopenapi-validator/responses.(*responseBodyValidator).checkResponseSchema(0x140005da440, 0x140004d1680, 0x140000d6480, {0x1400026c1c0?, 0x1039b44a0?}, 0x1400026b740)
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.0.56/responses/validate_body.go:152 +0x20c
github.com/pb33f/libopenapi-validator/responses.(*responseBodyValidator).ValidateResponseBody(0x140005da440, 0x140004d1680, 0x140000d6480)
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.0.56/responses/validate_body.go:66 +0x4bc
github.com/pb33f/libopenapi-validator.(*validator).ValidateHttpResponse(0x1400083a380, 0x140004d1680, 0x140000d6480)
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.0.56/validator.go:120 +0xbc
github.com/pb33f/wiretap/daemon.(*WiretapService).ValidateResponse(0x140007b2a90, 0x14000090300, 0x140000d6480)
        /home/runner/work/wiretap/wiretap/daemon/validate.go:19 +0x6c
created by github.com/pb33f/wiretap/daemon.(*WiretapService).handleHttpRequest in goroutine 1281
        /home/runner/work/wiretap/wiretap/daemon/handle_request.go:176 +0xad8

Due to compliance issues I'm not able to share the API file but would love to provide more information as required.

This seems to have come after #132

[daveshanley]

This issue is coming from another library we depend on for validating schemas:

https://github.com/santhosh-tekuri/jsonschema

The top four elements of the stack trace, are all from this library getting upset about trying to validate a schema against an object coming into wiretap.

I do not know what is causing the issue, there is no way to tell what did what. I would need to see an example request/response and the schema for that request/response as defined in the OpenAPI spec.

There is a way for wiretap to short circuit things if we know what schema element is breaking the underlying library. There is a nil pointer somewhere, but it could be anything.

Please send the details to support [at] pb33f.io if you do not wish to share publicly.

[savvyintegrations]

Hey @daveshanley. I'm getting the same error with this request, using the OAS doc I sent you yesterday:

curl http://localhost:9090/jobs -H "x-auth-context:eyJ0ZWFtSWQiOiI5NGJlZTE3MC0xN2IzLTQxN2ItOTQxMS05ZDUzMDI0YzBlMzUiLCJpc05vcmRpY2FuVGVhbSI6ZmFsc2UsInNvdXJjZUFwaVR5cGUiOiJyZXN0IiwicGxhblR5cGUiOiJQcm8iLCJjcmVhdGVkQXQiOiIyMDI0LTA2LTIxVDAzOjI2OjQ5LjI0MloiLCJhdXRoZW50aWNhdGlvblRva2VuVHlwZSI6ImFwaV9rZXkiLCJjb3JyZWxhdGlvbklkIjoiNDdiOWFjY2ItMzQ4Ni00NzQ2LWEzODItZmZlZTUwNThlNWU3IiwicmVxdWVzdGVySWQiOiI2MWM3MWNjOS1hZGY4LTQ1MzAtOWU4ZC01YjU4NWYxMTE0NWEiLCJyZXF1ZXN0ZXJUeXBlIjoiVGVhbU1lbWJlciIsInVzZXJBY2NvdW50SWQiOiI4Y2I1NDY1NC1iMWNiLTQ0ZTAtYTc1My01YzYyMzc0OGQ3NjUiLCJyb2xlIjoiQWRtaW4iLCJkZXZpY2VHcm91cHMiOltdfQ=="

You can probably disregard the custom header. We use it to run the API locally, bypassing an AWS Lambda authorizer. The base64-encoded string is an authorizer event instance.

[daveshanley]

Can you re-try this with v0.2.0 A lot of dependencies have been upgraded.

[timo102]

I get the same error in the latest version (wiretap_0.4.5_windows_x86_64):

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x30 pc=0x156ce31]

goroutine 6621 [running]:
github.com/santhosh-tekuri/jsonschema/v6.unevalFrom({0x17e74c0, 0xc0014cc570}, 0x0, 0x0)
        /home/runner/go/pkg/mod/github.com/santhosh-tekuri/jsonschema/v6@v6.0.1/validator.go:922 +0x131
github.com/santhosh-tekuri/jsonschema/v6.(*Schema).validate(0x0, {0x17e74c0, 0xc0014cc570}, 0x0, 0x0, 0x0, 0x0, 0x0)
        /home/runner/go/pkg/mod/github.com/santhosh-tekuri/jsonschema/v6@v6.0.1/validator.go:25 +0xa9
github.com/santhosh-tekuri/jsonschema/v6.(*Schema).Validate(...)
        /home/runner/go/pkg/mod/github.com/santhosh-tekuri/jsonschema/v6@v6.0.1/validator.go:16
github.com/pb33f/libopenapi-validator/responses.ValidateResponseSchema(0xc001978a00, 0xc00112a900, 0xc002377908, {0xc00129a000, 0x88f, 0xc00}, {0xc00125e580, 0x559, 0x580}, {0xc001143ca0, ...})
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/responses/validate_response.go:134 +0xa38
github.com/pb33f/libopenapi-validator/responses.(*responseBodyValidator).checkResponseSchema(0xc001734a20, 0xc001978a00, 0xc00112a900, {0xc00158d050, 0x10}, 0xc000cbfb60)
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/responses/validate_body.go:179 +0x60d
github.com/pb33f/libopenapi-validator/responses.(*responseBodyValidator).ValidateResponseBodyWithPathItem(0xc001734a20, 0xc001978a00, 0xc00112a900, 0x9acd1cffff00d5ab?, {0xc000300ac0, 0x1c})
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/responses/validate_body.go:78 +0x4ff
github.com/pb33f/libopenapi-validator.(*validator).ValidateHttpResponse(0xc000b00c80, 0xc001978a00, 0xc00112a900)
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/validator.go:131 +0x5a
github.com/pb33f/wiretap/daemon.(*WiretapService).ValidateResponse(0xc001822a90, 0xc001a95500, 0xc00112a900)
        /home/runner/work/wiretap/wiretap/daemon/validate.go:45 +0x76
created by github.com/pb33f/wiretap/daemon.(*WiretapService).handleHttpRequest in goroutine 6357
        /home/runner/work/wiretap/wiretap/daemon/handle_request.go:176 +0xf7f

[timo102]

Seems like a bug in the library libopenapi due to poor error checking:

[FloThinksPi]

Also got the same:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x88 pc=0x101634e64]

goroutine 63927 [running]:
github.com/pb33f/libopenapi-validator/errors.RequestContentTypeNotFound(0x14001a7f520, 0x1400323b900, {0x14000186240, 0x1c})
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/errors/request_errors.go:31 +0x354
github.com/pb33f/libopenapi-validator/requests.(*requestBodyValidator).ValidateRequestBodyWithPathItem(0x140019dc378, 0x1400323b900, 0x140013bd1f0?, {0x14000186240, 0x1c})
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/requests/validate_body.go:69 +0x474
github.com/pb33f/libopenapi-validator.(*validator).ValidateHttpRequestWithPathItem.func2(0x140014d8d90, 0x140014d8d20)
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/validator.go:243 +0x48
created by github.com/pb33f/libopenapi-validator.(*validator).ValidateHttpRequestWithPathItem in goroutine 63937
        /home/runner/go/pkg/mod/github.com/pb33f/libopenapi-validator@v0.4.5/validator.go:263 +0x240
error Command failed with exit code 1.

May be related ? pb33f/libopenapi-validator#167