Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper way to incorporate penalty.factor #20

Open
privefl opened this issue Feb 10, 2019 · 0 comments
Open

Proper way to incorporate penalty.factor #20

privefl opened this issue Feb 10, 2019 · 0 comments

Comments

@privefl
Copy link
Contributor

privefl commented Feb 10, 2019

Two questions/remarks:

  1. I would have expected the same results (with rescaled lambda sequences)
data(colon); X.bm <- as.big.matrix(colon$X); y <- colon$y
fit.lasso  <- biglasso(X.bm, y, family = 'gaussian')
fit.lasso2 <- biglasso(X.bm, y, family = 'gaussian',
                       penalty.factor = rep(100, ncol(X.bm)))

Looking at the code of {glmnet}, it seems that they rescale the multiplicative factors (by dividing by their mean). Should {biglasso} do the same here?

  1. What is the (implementation) problem with having some penalty factor as 0? (you don't allow unpenalized variables in the current version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant