Fix abstract-errored modules not getting inference info

Author: VonTum

src/compiler_top.rs

@@ -257,6 +257,10 @@ impl Linker {
         }
         self.checkpoint(&global_ids, AFTER_TYPE_CHECK_CP);
 
+        for (_, md) in &self.modules {
+            md.assert_valid();
+        }
+
         if config.early_exit == EarlyExitUpTo::AbstractTypecheck {
             return;
         }

src/flattening/mod.rs

@@ -90,6 +90,15 @@ impl Module {
         );
         (port_id, direction)
     }
+
+    pub fn assert_valid(&self) {
+        assert_eq!(
+            self.link_info.parameters.len(),
+            self.inference_info.parameter_inference_candidates.len(),
+            "{}",
+            self.link_info.name
+        );
+    }
 }
 
 /// Represents an opaque type in the compiler, like `int` or `bool`.

src/flattening/typecheck/mod.rs

@@ -140,17 +140,16 @@ pub fn typecheck(pass: &mut LinkerPass, errors: &ErrorCollector) {
     }
 
     // Skip printing not fully figured out types of there are type errors to reduce visual overhead.
-    if errors.did_error() {
-        return;
-    }
-    for (typ, span) in finalize_ctx.substitution_failures {
-        errors.error(
-            span,
-            format!(
-                "Could not fully figure out the type of this object. {}",
-                typ.display(globals.globals, link_info)
-            ),
-        );
+    if !errors.did_error() {
+        for (typ, span) in finalize_ctx.substitution_failures {
+            errors.error(
+                span,
+                format!(
+                    "Could not fully figure out the type of this object. {}",
+                    typ.display(globals.globals, link_info)
+                ),
+            );
+        }
     }
 
     if let GlobalObj::Module(md) = pass.get_mut() {