Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyrepl is not in a good state #47

Open
voidus opened this issue Apr 7, 2023 · 0 comments
Open

pyrepl is not in a good state #47

voidus opened this issue Apr 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@voidus
Copy link

voidus commented Apr 7, 2023

The pyrepl dependency seems to be not doing so well.

There is rarely any activity and the github and pypi versions have diverged: pypy/pyrepl#36

Additionally, there is python2-only syntax used:

> rg \\braise.\*,
pyrepl/pygame_keymap.py
93:                    raise KeySpecError, \
97:                    raise KeySpecError, "doubled \\C- (char %d of %s)"%(
103:                    raise KeySpecError, \
107:                    raise KeySpecError, "doubled \\M- (char %d of %s)"%(
122:                    raise KeySpecError, \
129:                    raise KeySpecError, \
135:                raise KeySpecError, \
164:                raise KeySpecError, \

pyrepl/python_reader.py
60:    raise cls, val, tb

pyrepl/pygame_console.py
302:        raise Exception, "erp!"

Not saying this to flame the people who worked on it of course, but it puts this package and its dependents in a precarious position. I'm using pdbpp in my daily work and haven't run into issues, so I assume the problematic code paths aren't used, but we should probably think if there is a way to support pyrepl or, if necessary, remove the dependency.

I understand that this might be a hard topic and hope we can find a good solution without explicit of implied shaming

@blueyed blueyed added the bug Something isn't working label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants