Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Skins Restorer integration #255

Open
pdinklag opened this issue Jul 31, 2024 · 0 comments
Open

Remove Skins Restorer integration #255

pdinklag opened this issue Jul 31, 2024 · 0 comments
Labels
Change Request Things that could be better.

Comments

@pdinklag
Copy link
Owner

pdinklag commented Jul 31, 2024

The Skins Restorer API is an unreliable mess that seems to be subject to unnecessary breaking changes and doesn't seem to work properly in various circumstances for unclear reasons (see #254 , #245, #240). So far, it has caused me more headache than it has really contributed to MinecraftStats and I don't see why I should fix here what's broken there - especially since whatever I do today may no longer work tomorrow.

To quote the SkinsRestorer API website:

Please note that this API is still work-in-progress. Expect breaking changes!

Until the Skins Restorer API works properly and reliably, the integration will be removed because I cannot maintain it.

The fact that it now requires Java 17 or later poses another issue that I will have to deal with at another time.

@pdinklag pdinklag added Change Request Things that could be better. Help Things that aren't really clear and may need documentation. labels Jul 31, 2024
@pdinklag pdinklag changed the title Make Skins Restorer integration opt-in Revoke Skins Restorer integration Jul 31, 2024
@pdinklag pdinklag changed the title Revoke Skins Restorer integration Remove Skins Restorer integration Jul 31, 2024
@pdinklag pdinklag removed the Help Things that aren't really clear and may need documentation. label Jul 31, 2024
pdinklag added a commit that referenced this issue Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Request Things that could be better.
Projects
None yet
Development

No branches or pull requests

1 participant