Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client update requirement handling #257

Open
pdinklag opened this issue Aug 6, 2024 · 1 comment
Open

Client update requirement handling #257

pdinklag opened this issue Aug 6, 2024 · 1 comment
Labels
Change Request Things that could be better.

Comments

@pdinklag
Copy link
Owner

pdinklag commented Aug 6, 2024

The next planned release of MinecraftStats will see the first client script upgrade since a good while.

Since going to Java, the web files have been separated from the CLI updater and thus need to be updated separately. Plugin users may have disabled the unpackWebFiles options if they modified the client style, so that the client won't auto update. Things will likely become a bit messy.

The server should write the Minecraft Stats version and minimum client version into the summary so that clients can check for themselves whether they need updating. In this case, they should display a message with a link to the proper readme section.

Ideally, this is done in combination with #120.

@pdinklag pdinklag added the Change Request Things that could be better. label Aug 6, 2024
@pdinklag
Copy link
Owner Author

pdinklag commented Aug 6, 2024

There may be another, more "forceful" way to solve this.

The updater, both CLI and plugin, knows the document root to where it will write the data directory. If there is an index.html in there, this could be marked (via comments in the first line, e.g.) with the MinecraftStats client version. If the server detects an outdated version, it can refuse to update until the client is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Request Things that could be better.
Projects
None yet
Development

No branches or pull requests

1 participant