Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lookup table primary keys strings [BREAKING] #6

Open
peabody124 opened this issue Jan 23, 2022 · 0 comments
Open

Make lookup table primary keys strings [BREAKING] #6

peabody124 opened this issue Jan 23, 2022 · 0 comments
Labels
breaking enhancement New feature or request

Comments

@peabody124
Copy link
Owner

Making the lookup tables strings would simplify the code and using integers in the primary key provides no benefit. This would break the database layout though, or at least be quite hard to migrate. Another consideration if extending the lookup tables might be to have additional optional fields that allow specifying what scripts to call out to, which would allow users to extend the system with no algorithms without modifying the core pipeline library.

@peabody124 peabody124 added enhancement New feature or request breaking labels Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant