New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't dismiss PR approval if the commit is a merge commit(?) #23

Open

miguel-vila opened this issue Mar 11, 2024 · 0 comments

miguel-vila commented Mar 11, 2024

Not sure if this is something we want to allow, but basically:

if a user does a merge commit updating the PR's branch, should we still allow that person approving the PR? this could be an opt-in config parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment