Implement std::error::Error for errors

[runfalk]

Currently the error type is Err(String) for most (maybe all) operations. This means you can't use this library with something like anyhow.

I've heard good things about thiserror. Maybe that's an alternative?

[pedrocr]

There's already an error type that uses std::error::Error:

rawloader/src/lib.rs

Lines 73 to 98 in 9c13d51

	/// Error type for any reason for the decode to fail
	#[derive(Debug)]
	pub struct RawLoaderError {
	msg: String,
	}
	impl fmt::Display for RawLoaderError {
	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
	write!(f, "RawLoaderError: \"{}\"", self.msg)
	}
	}
	impl Error for RawLoaderError {
	// Implement description so that older versions of rust still work
	fn description(&self) -> &str {
	"description() is deprecated; use Display"
	}
	}
	impl RawLoaderError {
	fn new(msg: String) -> Self {
	Self {
	msg,
	}
	}
	}

What else would be needed?

[runfalk]

I didn't realise there was such a struct already in place. It should be enough for anyhow. It just requires std::error::Error + Send + Sync + 'static.

I can try to update all places that still use a String and make them use RawLoaderError instead then?

[pedrocr]

Go ahead if you want. The reason I didn't bother was that those are all internal to the crate and so don't affect the API.