Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CodeMirror 6 #296

Open
hildjj opened this issue Jun 12, 2022 · 4 comments
Open

Update to CodeMirror 6 #296

hildjj opened this issue Jun 12, 2022 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@hildjj
Copy link
Contributor

hildjj commented Jun 12, 2022

The online page currently uses an old version of CodeMirror 5. We would like to upgrade to CodeMirror 6.

This would be a great first bug if you've worked with CM6 before, and would like to contribute to Peggy. It's likely that the pegjs language mode for CM5 will also need to be rewritten for this to work. In that case, we'll be happy to host a new project in the PeggyJS GitHub org, and give you control over that repo.

@hildjj hildjj added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 12, 2022
@reverofevil
Copy link

reverofevil commented Jun 13, 2022

  1. Monaco editor isn't really that hard to set up. Why not switch to an editor that can support something like this? (ugliest code alert; press Next and hover in either column);
    image
  2. Would you consider a PR with more serious rewrite for the /online page? I probably know where the idea of CodeMirror came from, but probably could do better this time.
    image

@hildjj
Copy link
Contributor Author

hildjj commented Jun 13, 2022

Yes, I'd look at a PR that switched to something that isn't CodeMirror. I'm not tied to CM at all, and maintenance costs matter to me, so simpler is better particularly for non-core functionality.

@Mingun
Copy link
Member

Mingun commented Jun 13, 2022

Yeah, I was actually also thinking, would not switch to monaco?

Having dark theme also would be very appreciating!

@hildjj
Copy link
Contributor Author

hildjj commented Jul 22, 2023

I am strongly in favor of moving to Monaco, after having tried it on another project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants