Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Invalid Semver Error #37

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

jarretmoses
Copy link
Collaborator

@jarretmoses jarretmoses commented Oct 15, 2017

What: Solving issue #36

Why: This change fixes an issue where the React Native version wasn't in a correct format for compare-versions package (ie ^0.49.3 vs 0.49.3).

How:

  • Adding semver package dependency package.json
  • Clean React Native version with semver.clean

Checklist:

refactor: make sure rnVersion is properly formatted for conditional
@jarretmoses
Copy link
Collaborator Author

@peggyrayzis I believe there should be some test for this but I am thinking of a proper approach. If you have any input let me know!

@jarretmoses jarretmoses changed the title [WIP]hotfix/invalid-semver [WIP] Fix invalid Semver Error Oct 15, 2017
@jarretmoses jarretmoses changed the title [WIP] Fix invalid Semver Error [WIP] hotfix: Fix invalid semver Error Oct 15, 2017
@jarretmoses jarretmoses changed the title [WIP] hotfix: Fix invalid semver Error [WIP] hotfix: invalid semver Error Oct 15, 2017
@jarretmoses jarretmoses changed the title [WIP] hotfix: invalid semver Error [Hotfix] Invalid semver Error Feb 10, 2018
@jarretmoses jarretmoses changed the title [Hotfix] Invalid semver Error [Hotfix] Invalid Semver Error Feb 10, 2018
@jarretmoses
Copy link
Collaborator Author

@dlowder-salesforce I've added your Github version PR to this PR as best I could. One thing that was confusing was that in your PR you used the compareVersions package by passing a null value when it didn't pass the semver test. However, this continuously threw for me as it seems compareVersions doesn't support null values to compare against.

@douglowder
Copy link

@jarretmoses that's weird, I don't remember hitting an issue with setting version to null. I'll have a look.

@jarretmoses
Copy link
Collaborator Author

@dlowder-salesforce any luck with that null issue? Also if you wouldn't mind could you let me know if my addition of your PR is solving the issue of your original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants