-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix] Invalid Semver Error #37
base: master
Are you sure you want to change the base?
[Hotfix] Invalid Semver Error #37
Conversation
refactor: make sure rnVersion is properly formatted for conditional
@peggyrayzis I believe there should be some test for this but I am thinking of a proper approach. If you have any input let me know! |
refactor: move semver check into file-operations.js test: update test for version check and update snapshot
test: add kotlin test for github RN version
@dlowder-salesforce I've added your Github version PR to this PR as best I could. One thing that was confusing was that in your PR you used the |
@jarretmoses that's weird, I don't remember hitting an issue with setting version to |
@dlowder-salesforce any luck with that |
What: Solving issue #36
Why: This change fixes an issue where the React Native version wasn't in a correct format for
compare-versions
package (ie^0.49.3
vs0.49.3
).How:
package.json
semver.clean
Checklist: