Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON view #4

Closed
missinglink opened this issue Mar 6, 2020 · 4 comments · Fixed by #10
Closed

JSON view #4

missinglink opened this issue Mar 6, 2020 · 4 comments · Fixed by #10

Comments

@missinglink
Copy link
Member

Heya,

I'm seeing some alarming red circles and also some "0" entries where it should be a string?

Screenshot_20200306-230439

Android, chrome beta
@missinglink
Copy link
Member Author

Seems I'm not the only one seeing this, pelias/polylines#244

@blackmad is there some way we can at least get rid of those 0's which make it look like some properties are arrays when they aren't?

@blackmad
Copy link
Contributor

super sorry, don't know why I just saw the notification for this.

yes will look into this asap.

@blackmad
Copy link
Contributor

this is two little issues

  1. was rendering linkifed GIDs as lists. FIXED
  2. those little red circles are supposed to be so you can expand/collapse parts of the JSON if you are hunting around. Since they're confusing folks and I don't know that they'll be used often, I just got rid of them for now.

blackmad added a commit that referenced this issue Mar 11, 2020
@blackmad
fix linkified GIDs and hide collpase icons
b44ba01 
fixes #4
@blackmad blackmad mentioned this issue Mar 11, 2020
Merged
@blackmad
Copy link
Contributor

also added a copy json button to make it even easier #11

blackmad added a commit that referenced this issue Mar 12, 2020
@blackmad
fix linkified GIDs and hide collpase icons (#10)
fe0bb43 
fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix linkified GIDs and hide collpase icons pelias/compare
2 participants
@blackmad @missinglink