From d0fa51ed01b85604d7e4d72a2baa0cefed13ac0f Mon Sep 17 00:00:00 2001 From: Ian Wagner Date: Thu, 20 Feb 2025 23:58:35 +0900 Subject: [PATCH] Patches for bugs introduced in 2.4 and 2.5 releases --- classifier/scheme/venue.js | 2 +- .../dictionaries/nb/concatenated_suffixes_separable.txt | 3 +-- test/address.esp.test.js | 5 +++++ test/address.usa.test.js | 5 +++++ 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/classifier/scheme/venue.js b/classifier/scheme/venue.js index fae74356..a420a61b 100644 --- a/classifier/scheme/venue.js +++ b/classifier/scheme/venue.js @@ -186,7 +186,7 @@ module.exports = [ scheme: [ { is: ['PlaceClassification', 'VenueClassification'], - not: ['StreetClassification'] + not: ['StreetClassification', 'StreetSuffixClassification'] }, { is: ['AlphaClassification'], diff --git a/resources/libpostal/dictionaries/nb/concatenated_suffixes_separable.txt b/resources/libpostal/dictionaries/nb/concatenated_suffixes_separable.txt index a67d5c55..8a4e8037 100644 --- a/resources/libpostal/dictionaries/nb/concatenated_suffixes_separable.txt +++ b/resources/libpostal/dictionaries/nb/concatenated_suffixes_separable.txt @@ -1,6 +1,5 @@ -allè|alle allèen|alleen veg|v. vegen|v.|vn. vei|v. -veien|v.|vn. \ No newline at end of file +veien|v.|vn. diff --git a/test/address.esp.test.js b/test/address.esp.test.js index a63a43b8..643386e0 100644 --- a/test/address.esp.test.js +++ b/test/address.esp.test.js @@ -5,6 +5,11 @@ const testcase = (test, common) => { { street: 'Carrer d\'Aragó' }, { housenumber: '155' }, { postcode: '08011' }, { locality: 'Barcelona' } ]) + + assert('Calle Principal 20 Barcelona', [ + { street: 'Calle Principal' }, { housenumber: '20' }, + { locality: 'Barcelona' } + ]) } module.exports.all = (tape, common) => { diff --git a/test/address.usa.test.js b/test/address.usa.test.js index 50abb10a..c3ae0f57 100644 --- a/test/address.usa.test.js +++ b/test/address.usa.test.js @@ -285,6 +285,11 @@ const testcase = (test, common) => { // https://github.com/pelias/pelias/issues/912 assert('Jefferson Parish', [{ locality: 'Jefferson' }]) assert('Mills County', [{ locality: 'Mills' }]) + + // Partial admin match that triggered a regression in 2.5.0 + assert('Main St Seattl', [ + { street: 'Main St' } + ]) } module.exports.all = (tape, common) => {