Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Enshrouded - Updated egg-enshrouded.json for new server role configuration #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Parker-Bergen
Copy link

Updated eggs to work for new server role configuration released in Update 2 (v0.7.2.0) - Melodies of the Mire

Description

This PR updates the eggs to be compatible with the new server role configuration introduced in Update 2 (v0.7.2.0) - Melodies of the Mire. The updates include modifications to the startup command and configuration files to align with the new environment variables and server settings.

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

Updated eggs to work for new server role configuration released in Update 2 (v0.7.2.0) - Melodies of the Mire
@Parker-Bergen Parker-Bergen changed the title Updated for new server role configuration Enshrouded - Updated for new server role configuration Nov 24, 2024
@Parker-Bergen Parker-Bergen changed the title Enshrouded - Updated for new server role configuration Update: Enshrouded - Updated egg-enshrouded.json for new server role configuration Nov 24, 2024
@gOOvER
Copy link
Contributor

gOOvER commented Nov 24, 2024

thats not the only change. there are 2 other passwords.

i would Not set them via parsing

Game port is no longer used. Only query port is used now, so we can default it to the server default port
@Parker-Bergen
Copy link
Author

thats not the only change. there are 2 other passwords.

i would Not set them via parsing

Yes but it will only generate 1 (Default) group when the password is set in the config. It is set to nothing, but the game believes that it is set and therefore there will only be the default group. How would I set it without the parser if I could get it to generate the 3 groups as a new server?

@gOOvER
Copy link
Contributor

gOOvER commented Nov 25, 2024

thats part of the original config:

"userGroups": [
        {
            "canAccessInventories": true,
            "canEditBase": true,
            "canExtendBase": true,
            "canKickBan": true,
            "name": "Admin",
            "password": "AdminwcrHuhOB",
            "reservedSlots": 0
        },
        {
            "canAccessInventories": true,
            "canEditBase": true,
            "canExtendBase": false,
            "canKickBan": false,
            "name": "Friend",
            "password": "Friendvd6M-T(Q",
            "reservedSlots": 0
        },
        {
            "canAccessInventories": false,
            "canEditBase": false,
            "canExtendBase": false,
            "canKickBan": false,
            "name": "Guest",
            "password": "GuestzkKd]3Ks",
            "reservedSlots": 0
        }
    ]
}

Its not possible to parse this, because you have 3 times "password".

Users can set this via Filemanager.

@Parker-Bergen
Copy link
Author

Parker-Bergen commented Nov 27, 2024

I will look over and try and come up with a better solution. I would like it to be as simple as possible by filling out the egg params.
However the code I have submitted does work just by filling out egg params and launching

Update:
Btw the JSON template you showed here seems to be the one you use for your egg, however the egg in this repo does not use this and is more basic, which is why the setup I had was functional with parsing only the first object

@QuintenQVD0
Copy link
Contributor

I will look over and try and come up with a better solution. I would like it to be as simple as possible by filling out the egg params. However the code I have submitted does work just by filling out egg params and launching

Update: Btw the JSON template you showed here seems to be the one you use for your egg, however the egg in this repo does not use this and is more basic, which is why the setup I had was functional with parsing only the first object

The config here is an older version that does not work anymore.

@Parker-Bergen
Copy link
Author

I will look over and try and come up with a better solution. I would like it to be as simple as possible by filling out the egg params. However the code I have submitted does work just by filling out egg params and launching

Update: Btw the JSON template you showed here seems to be the one you use for your egg, however the egg in this repo does not use this and is more basic, which is why the setup I had was functional with parsing only the first object

The config here is an older version that does not work anymore.

I understand the one is this repo does not work anymore. I was referring to the json config goover provided in this thread. Unless you are also referring to that, and it doesn't work either?

@gOOvER
Copy link
Contributor

gOOvER commented Nov 27, 2024

I understand the one is this repo does not work anymore. I was referring to the json config goover provided in this thread. Unless you are also referring to that, and it doesn't work either?

Thats was only a part of the new config. There are much more. ATM its not possible to parse this correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants